| 9 Jan 2025 |
GGG | But yeah, there's no point | 16:00:36 |
6pak | yes I know, but do we need those for programs in nixpkgs | 16:00:41 |
GGG | We could likely replace it with a `makeBinaryWrapper` | 16:00:54 |
6pak | it's just unnecessary work on startup to find the dotnet runtime, and makes it less deterministic | 16:00:57 |
GGG | Well, for some programs it's useful since they want to use the installed SDK | 16:01:22 |
GGG | Like roslyn-ls | 16:01:27 |
GGG | But other than those, it's not really necessary | 16:01:36 |
6pak | in that case you should have a custom bootstrapper that takes global.json into account | 16:02:22 |
GGG | There's no global.json for programs in $PATH though | 16:02:48 |
6pak | I mean if you want roslyn-ls to use the same roslyn as the only that builds the project, then it would have to read the global.json | 16:03:49 |
6pak | becuase a normal apphost will use whatever version deps.json of the program specifies | 16:04:09 |
6pak | * because a normal apphost will use whatever version deps.json of the program specifies | 16:04:21 |
GGG | Oh no, roslyn-ls is a language server, so the user uses it when already having a .NET SDK installed in their system | 16:04:28 |
GGG | And not every project has a global.json | 16:04:37 |
6pak | it should imo | 16:05:01 |
GGG | I don't see the need for it to exist imo | 16:05:16 |
6pak | but does roslyn-ls bundle it's own roslyn binary or uses one from .net sdk | 16:05:20 |
GGG | In reply to @6pak:matrix.org but does roslyn-ls bundle it's own roslyn binary or uses one from .net sdk I have no idea | 16:05:40 |
6pak | sdk major/feature-band updates can bring breaking changes | 16:05:55 |
6pak | wym by this | 16:06:06 |
GGG | In reply to @6pak:matrix.org sdk major/feature-band updates can bring breaking changes I mean, shouldn't TFM take care of that already | 16:06:19 |
6pak | I mean build system breaking changes | 16:06:34 |
GGG | In reply to @6pak:matrix.org wym by this Because some programs want to use whatever SDK(s) the user has installed on their system | 16:06:45 |
GGG | Like roslyn-ls | 16:06:57 |
GGG | Can't remember if there's others | 16:07:04 |
GGG | But we have a flag for it in `buildDotnetModule` | 16:07:14 |
6pak | SDK or runtime | 16:07:52 |
GGG | In reply to @6pak:matrix.org SDK or runtime The runtime in the SDK really, since they'll use the SDK themselves as well | 16:08:28 |
6pak | it does bundle it's own | 16:11:35 |
6pak | so I'm not really sure why it would need this | 16:11:47 |