| 17 Dec 2024 |
 6pak | and have a flexible way to gather nuget deps | 22:19:13 |
 GGG | In reply to @6pak:matrix.org
imo exposing procedural bash helpers instead is the way to go That's not the standard in nixpkgs currently though | 22:19:14 |
| GGG | It'd be very confusing | 22:19:18 |
 Corngood | projectReferences is just buildInputs now | 22:19:28 |
| GGG | And inconsistent with the rest of nixpkgs | 22:19:29 |
| GGG | I'd rather have buildDotnetModule but also be able to use individual helpers to do the more complicated stuff if people want. | 22:19:59 |
| 6pak | yeah I just mean you can't easily replace ProjectReference with PackageReference in msbuild | 22:20:22 |
| 6pak | both have their own quirks | 22:20:26 |
| 6pak | with former you can specify a different target to build and do crazy stuff | 22:20:58 |
| GGG | Yeah, .NET really wasn't made to work like this, were really trying to shove a square cube into a circle | 22:21:00 |
| GGG | * Yeah, .NET really wasn't made to work like this, were really trying to shove a square cube into a circle hole | 22:21:08 |
| 6pak | * with former you can specify a different target to build and do crazy stuff, the latter auto imports stuff like build.props and analyzers which the former doesn't annoyingly | 22:21:25 |
| GGG | * Yeah, .NET really wasn't made to work like this, we're really trying to shove a square cube into a circle hole | 22:21:26 |
 Whovian9369 | So it looks like my current issue is that some language details that I'm unfamiliar with (as I'm not a C# dev)
For example, /build/source/Aaru.Images/AaruFormat/Write.cs(4356,58): error CS9194: Argument 2 may not be passed with the 'ref' keyword in language version 8.0. To pass 'ref' arguments to 'in' parameters, upgrade to language version 12.0 or greater. [/build/source/Aaru.Images/Aaru.Images.csproj] | 22:22:55 |
| Whovian9369 | * So it looks like my current issue is that some language details that I'm unfamiliar with (as I'm not a C# dev)
For example, /build/source/Aaru.Images/AaruFormat/Write.cs(4356,58): error CS9194: Argument 2 may not be passed with the 'ref' keyword in language version 8.0. To pass 'ref' arguments to 'in' parameters, upgrade to language version 12.0 or greater. [/build/source/Aaru.Images/Aaru.Images.csproj]
Edit: Sorry for interrupting!
| 22:23:10 |
| Corngood | So this is something meant to build with an older SDK? You may just have to fix things like that unfortunately. | 22:24:51 |
| Corngood | Or maybe you just need to set an explicit language version? | 22:25:52 |
| Corngood |
CS9194: Argument may not be passed with the ref keyword. To pass ref arguments to in parameters, upgrade to language version 12 or greater.
| 22:26:38 |
| Whovian9369 | Yeah, I just remembered that it's originally a netcoreapp3.1 app and not a net7.0 one, so I have to manually substituteInPlace to go from one to the other to get it to build with net7.0. | 22:26:43 |
| Whovian9369 | * Yeah, I just remembered that it's originally a netcoreapp3.1 app and not a net7.0 one, so I have to manually substituteInPlace to go from one to the other to get it to build with net7.0. (Likely to get it to build in the first place, haha.) | 22:27:10 |
| Corngood | do the project files have LangVersion? | 22:27:28 |
| 6pak | it does https://github.com/aaru-dps/Aaru/blob/v5.3.2/Aaru.Images/Aaru.Images.csproj#L20 | 22:27:58 |
| 6pak | no clue how it compiled in the first place | 22:28:02 |
| Corngood | maybe the have build scripts that override it or something? | 22:28:32 |
| Corngood | * maybe they have build scripts that override it or something? | 22:28:36 |
 Samuel | In reply to @6pak:matrix.org
it does https://github.com/aaru-dps/Aaru/blob/v5.3.2/Aaru.Images/Aaru.Images.csproj#L20 Huh that's cursed | 22:28:50 |
| Corngood | maybe try with -p:LangVersion=12.0 or latest | 22:29:12 |
| Whovian9369 | Trying with that, thank you! | 22:30:09 |
| Whovian9369 | Also thank you all so much for the thoughts here! | 22:30:18 |
| Corngood | So the v5.3.2 tag is what you're building? Looks like the main branch has newer LangVersion set. | 22:31:08 |
