| 17 Dec 2024 |
 Whovian9369 | (Also I have dotnetBuildFlags and dotnetInstallFlags set separately since I remember having issues via dotnetFlags -- Something relating to the restore phase, if memory serves? I'll have to try that again later.) | 21:57:50 |
 6pak | 
Download image.png | 21:58:11 |
| 6pak | but for the actual build, it only does sometimes... | 21:58:39 |
| 6pak | 
Download image.png | 21:58:42 |
| 6pak | for some reason | 21:58:43 |
| 6pak | tbh I hate everything about buildDotnetModule | 21:58:58 |
| 6pak | it's just so wrong | 21:59:01 |
 GGG | Oh yeah, I wonder if we should fill `RuntimeIdentifiers` based on the supported platforms in meta | 21:59:27 |
| 6pak | no | 21:59:35 |
| 6pak | you should fill it out based on hostPlatform | 21:59:43 |
| 6pak | * you should fill it out based on hostSystem | 21:59:46 |
| GGG | That might solve a few issues | 21:59:48 |
| GGG | Would have to evaluate the impact of doing that widespread though | 22:00:02 |
| 6pak | this is where the fact I had the convo with Corngood in dms backfires... | 22:00:14 |
| GGG | In reply to @6pak:matrix.org
you should fill it out based on hostSystem No, the RuntimeIdentifiers should have all supported platforms, no? | 22:00:45 |
| 6pak | it should have everything you currently want to build | 22:01:06 |
| 6pak | and in the nixpkgs model, you can only build one at a time | 22:01:11 |
| GGG | Then the `--runtime` flag tells which one were building for | 22:01:12 |
| GGG | In reply to @6pak:matrix.org
it should have everything you currently want to build But if we only set it to one, then it'll screw over the restore process and fetch-deps | 22:01:47 |
| 6pak | afaik RuntimeIdentifiers only affects nuget restore | 22:01:48 |
| GGG | Yeah | 22:01:55 |
| 6pak | and it doesn't make sense to download stuff you don't need to build what you want | 22:01:56 |
| 6pak | because it's wrong imo | 22:02:18 |
| GGG | Which is why I was thinking of setting it based on the `meta.supportedPlatforms` | 22:02:24 |
| GGG | That way it'd only restore for the platforms it supports | 22:02:37 |
| 6pak | fetch-deps output should be specific for the platform | 22:02:39 |
| GGG | No, I disagree with that | 22:02:51 |
| 6pak | because you shouldn't need to download unfree windows deps if you build a linux app | 22:02:57 |
| 6pak | just because it supports windows target | 22:03:01 |
| GGG | Sure, we can have per platform dependencies in the file | 22:03:05 |
