!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture

194 Members
Discussions about Nixpkgs' architecture - https://github.com/NixOS/nixpkgs/labels/architecture52 Servers

Load older messages


SenderMessageTime
8 Jul 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @philiptaron:matrix.org

When I run maintainers/scripts/check-by-name.sh master locally in my nixpkgs repository, without any changes, I get this error:

I/O error:  Failed to get the definition info for attribute acl: In /tmp/tmp.bQmCobXFGj/merged/pkgs/stdenv/linux/default.nix, attribute parent node is not an attribute path node: NODE_INHERIT@28432..28603

Does anyone else reproduce this? It appears to be about this line in pkgs/stdenv/linux/default.nix:

inherit (prevStage)
          gzip bzip2 xz bash coreutils diffutils findutils gawk
          gnused gnutar gnugrep gnupatch patchelf
          attr acl zlib libunistring;
I've opened https://github.com/NixOS/nixpkgs-check-by-name/issues/78 for this issue. Doing some diagnostics now.
20:20:36
@philiptaron:matrix.orgPhilip Taron (UTC-8) And https://github.com/NixOS/nixpkgs-check-by-name/pull/79 now too in order to fix it. CC willbush and infinisil . 20:45:05
@qyriad:katesiria.orgQyriad
In reply to@emilazy:matrix.org
(I would certainly be happy to see those go, as they obviously don't compose)
have you seen the lib.extendMkDerivation PR?
20:50:55
@emilazy:matrix.orgemilynope, thanks for the pointer; subscribed20:52:12
@emilazy:matrix.orgemilyit seems like it still wouldn't work with the by-name model though20:52:22
@emilazy:matrix.orgemily I sort of imagine we want a world where it looks like stdenv.mkDerivation { mixins = [ qtMixin pythonMixin ]; … } or something 20:52:50
@emilazy:matrix.orgemily I guess we could write something like qtMixin (pythonMixin stdenv.mkDerivation) { … }? 20:53:04
@emilazy:matrix.orgemily well, it's really the callPackages that are the problem though, not mkDerivation 20:53:17
@emilazy:matrix.orgemilywhich gets into splicing stuff that I've never fully understood20:53:32
@colin:uninsane.orgColin
In reply to @emilazy:matrix.org
I sort of imagine we want a world where it looks like stdenv.mkDerivation { mixins = [ qtMixin pythonMixin ]; … } or something

both buildRustPackage and buildPythonPackage can be replaced with stdenv.mkDerivation and adding the appropriate setup hooks to nativeBuildInputs (e.g. cargoSetupHook or pypaSetupHook). i think the qt5.callPackage stuff is in a similar state.

the Python folk seem very against the idea of replacing buildPythonPackage with mkDerivation. i think there's more appetite for that on the Rust front.

21:01:05
@colin:uninsane.orgColin
In reply to @emilazy:matrix.org
I sort of imagine we want a world where it looks like stdenv.mkDerivation { mixins = [ qtMixin pythonMixin ]; … } or something
*

both buildRustPackage and buildPythonPackage can be replaced with stdenv.mkDerivation and adding the appropriate setup hooks to nativeBuildInputs (e.g. cargoSetupHook or pypaBuildHook). i think the qt5.callPackage stuff is in a similar state.

the Python folk seem very against the idea of replacing buildPythonPackage with mkDerivation. i think there's more appetite for that on the Rust front.

21:02:59
@qyriad:katesiria.orgQyriad buildPythonPackage very recently became a fair bit more than equivalent to mkDerivation with some setup hooks, now that it takes the pythonic dependencies and build-system arguments and mkDerivation-ifies them 21:22:18
9 Jul 2024
@emilazy:matrix.orgemilyright03:17:17
@emilazy:matrix.orgemily what about the callPackages? are those "just" the same as callPackage that brings another namespace into scope too? I've never been entirely clear on that 03:17:40
@tomberek:matrix.orgtomberek emily: The callPackages serve the same purpose, but there are minor differences in how some of the package sets are put together due to historical accident. This is why each package set (eg: pythonPackages, rubyPackages, etc) has differing behavior and instructions for use. Standardizing these would be a huge win. 03:53:19
@emilazy:matrix.orgemilyit's always been a little funny to me that Nixpkgs of all things bakes in an assumption that a piece of software uses at most one ecosystem :)03:54:18
12 Jul 2024
@infinisil:matrix.orginfinisilI'll be in my weekly office hour again today in 10 minutes: https://meet.jit.si/nixpkgs-architecture :)17:51:22
@infinisil:matrix.orginfinisil

Ping @willbush:matrix.org @philiptaron:matrix.org @dmills27:matrix.org @raf:notashelf.dev @emilazy:matrix.org in case anybody wants to join :)

17:52:48
14 Jul 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
I'll be in my weekly office hour again today in 10 minutes: https://meet.jit.si/nixpkgs-architecture :)
I plan on attending this coming week, as I will be at home as opposed to travelling.
23:48:26
15 Jul 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8) infinisil: I'm blocked on adding the regression test you asked for in #79 by failing to understand how to ask Nix for the line/position numbers. 15:00:22
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): I was about to hit enter haha: https://github.com/NixOS/nixpkgs-check-by-name/pull/79#issuecomment-2228713375 15:01:02
@philiptaron:matrix.orgPhilip Taron (UTC-8)Sweet!15:01:15
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
Philip Taron (UTC-8): I was about to hit enter haha: https://github.com/NixOS/nixpkgs-check-by-name/pull/79#issuecomment-2228713375
All right, it's available for your perusal.
17:01:45
19 Jul 2024
@infinisil:matrix.orginfinisil I'll have the weekly office hour in 5 mins, will take a look at the above there Philip Taron (UTC-8) :) 17:54:50
@philiptaron:matrix.orgPhilip Taron (UTC-8)Thanks! I thought I was going to be able to attend but I’m out on an errand at the moment.17:55:46
@infinisil:matrix.orginfinisilNo worries18:01:27
@infinisil:matrix.orginfinisil I'm chilling in https://meet.jit.si/nixpkgs-architecture :) (cc Dominic Mills willbush) 18:02:03
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): I'm guessing you wouldn't mind if I force pushed on your PR with some small improvements? :P 18:18:49
@philiptaron:matrix.orgPhilip Taron (UTC-8)Not at all18:54:44
@infinisil:matrix.orginfinisilEnded up doing a separate PR: https://github.com/NixOS/nixpkgs-check-by-name/pull/83 :P21:08:58

There are no newer messages yet.


Back to Room ListRoom Version: 9