| 25 Jul 2024 |
|  @willpower3309:matrix.org left the room. | 15:09:31 |
 Philip Taron (UTC-8) | I have a set of PRs related to pkgs/top-level/release-attrpaths-superset.nix and the __attrsFailEvaluation attributes sprinkled through nixpkgs. I'd appreciate any reviews and merging.
They're all linked to https://github.com/NixOS/nixpkgs/issues/324619.
| 23:40:23 |
| 26 Jul 2024 |
 infinisil | Philip Taron (UTC-8): Tested and merged, except for the two with merge conflicts :) | 00:07:02 |
| Philip Taron (UTC-8) | Thank you so much!!! | 00:07:29 |
| infinisil | Btw I think a bunch of these could've been done in the same PR with multiple commits, makes it easier to test | 00:07:31 |
| infinisil | I used
for b in $(git branch --remote --list 'philiptaron/__attrsFailEvaluation/*'); do
git merge "$b"
done
| 00:08:03 |
| infinisil | To test all of them together :P | 00:08:08 |
| Philip Taron (UTC-8) | I’m gun shy on that: I’ve gotten so much “I can’t review this” negative feedback on “treewide” changes | 00:08:15 |
| Philip Taron (UTC-8) | They originated as a single branch! | 00:08:33 |
| infinisil | Haha | 00:08:39 |
| infinisil | I see, no worries ;) | 00:08:51 |
| infinisil | I usually want to err on the side of "merge fast and often", which I guess does work better with smaller PRs, but it's hard to strike the balance | 00:10:06 |
| Philip Taron (UTC-8) | Don't I know it. I also like merge fast and often, but, uh, that relies on fast reviews and merges, which are only some of the time present (for obvious open source reasons!) | 00:11:01 |
| infinisil | Yeah 😅 | 00:11:55 |
| infinisil | Philip Taron (UTC-8): Hmm weird, https://github.com/NixOS/nixpkgs-check-by-name/blob/main/.github/workflows/after-release.yml didn't run | 23:29:38 |
| infinisil | https://github.com/NixOS/nixpkgs-check-by-name/actions/workflows/after-release.yml | 23:29:47 |
| Philip Taron (UTC-8) | I saw that. The release went out, though./ | 23:30:09 |
| Philip Taron (UTC-8) | * I saw that. The release went out, though. | 23:30:11 |
| infinisil | It definitely worked before 🤔 https://github.com/NixOS/nixpkgs/pull/303140 | 23:34:26 |
| infinisil | For others checkin in here, gonna work around it: https://github.com/NixOS/nixpkgs-check-by-name/pull/90 | 23:44:05 |
| infinisil | Philip Taron (UTC-8): Oh no, the Cargo.lock is still at 0.1.1, why did this not break anything 😆 | 23:46:07 |
| Philip Taron (UTC-8) | Must be some consequence of the cargo update changes?? | 23:48:10 |
| infinisil | I noticed it from those: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/10118954269#summary-27986608230 | 23:48:51 |
| infinisil | But like, I'd expect the build itself to fail from this | 23:49:09 |
| infinisil | Not sure what the consequences of a mismatched Cargo.{toml,lock} are | 23:49:47 |
| infinisil | Philip Taron (UTC-8): I guess I should finish the Changelog PR, because there it would be handled automatically: https://github.com/NixOS/nixpkgs-check-by-name/pull/46/files#diff-d9002f82f23cc9b3c1545ec7d5ddfc3911aec8ba24d4e3d21c73f40355da2a16R85
cargo set-version --manifest-path "$root"/Cargo.toml "$next"
This updates both Cargo.{toml,lock}, without updating anything else :)
| 23:55:42 |
| 27 Jul 2024 |
| infinisil | * Philip Taron (UTC-8): I guess I should finish the Changelog PR, because there it would be handled automatically: https://github.com/NixOS/nixpkgs-check-by-name/pull/46/files#diff-d9002f82f23cc9b3c1545ec7d5ddfc3911aec8ba24d4e3d21c73f40355da2a16R85
cargo set-version --manifest-path "$root"/Cargo.toml "$next"
This updates the version in both Cargo.{toml,lock}, without updating anything else :)
| 00:05:49 |
| 29 Jul 2024 |
|  @imincik:matrix.org left the room. | 10:01:47 |
| 1 Aug 2024 |
|  Sigmanificient joined the room. | 11:40:49 |
| 3 Aug 2024 |
|  Randy Eckenrode joined the room. | 14:24:05 |
