| 10 Jan 2024 |
 problems | ah, okay | 22:09:40 |
 infinisil | https://discourse.nixos.org/t/ci-will-soon-enforce-pkgs-by-name-for-new-packages/38098 | 22:29:39 |
| 11 Jan 2024 |
 kaction | Hello. I as promised, I created pre-RFC about feature parameter names. https://discourse.nixos.org/t/pre-rfc-standardization-of-feature-parameters/38104 | 03:45:24 |
| 13 Jan 2024 |
 9999years | added some customization options to writeShellApplication, would appreciate a review
https://github.com/NixOS/nixpkgs/pull/280592 | 00:53:31 |
| 15 Jan 2024 |
| infinisil | Reminder that we'll have the final review & merge party for https://github.com/NixOS/nixpkgs/pull/275539 in 20 minutes in https://meet.jit.si/nixpkgs-architecture! | 15:38:58 |
 John Ericson | :) | 15:59:33 |
| John Ericson | finally gonna make it | 15:59:36 |
| infinisil | Philip Taron (UTC-8): Joining? | 16:02:47 |
| infinisil | Robert Hensing (roberth): It's on my side, hopefully should be fixed in a bit, stay tight! | 16:49:05 |
| infinisil | I'll rejoin when it's good again | 16:49:17 |
| John Ericson | https://doc.rust-lang.org/std/macro.file.html | 17:04:48 |
| infinisil | Tests now fixed, I'll merge once ofborg is happy! | 17:51:57 |
 Rick (Mindavi) | 🙌🏼🎉🎉 | 17:52:32 |
| 16 Jan 2024 |
| infinisil | Bad news, there's another problem with the PR, one that would break all CI runs when the channel updates in a couple days 😅 | 17:07:24 |
| infinisil | Working on both a fix but also future prevention of this, will follow up later | 17:08:13 |
| infinisil | https://github.com/NixOS/nixpkgs/pull/281374 | 18:51:07 |
| infinisil | This should be merged relatively quickly ^
I'll definitely merge this myself in like the next 6 hours to prevent master from breaking when the next nixos-unstable channel happens (well, the next next update, not the immediately next one) | 18:53:10 |
| infinisil | And here's the problem and fix: https://github.com/NixOS/nixpkgs/pull/281390 (this is not urgent) | 20:36:31 |
| infinisil | In reply to @infinisil:matrix.org
https://github.com/NixOS/nixpkgs/pull/281374 Now merged, thanks for all the accepting eyes on it! | 21:01:36 |
| infinisil | In reply to @infinisil:matrix.org
And here's the problem and fix: https://github.com/NixOS/nixpkgs/pull/281390 (this is not urgent) We don't need to rush this, but it's a small PR and it contains the fix without which we can't proceed to make pkgs/by-name required for new packages. Reviews appreciated :) | 21:02:57 |
 Philip Taron (UTC-8) | In reply to @infinisil:matrix.org
We don't need to rush this, but it's a small PR and it contains the fix without which we can't proceed to make pkgs/by-name required for new packages. Reviews appreciated :) Done. Not much to say, other than a wonder about what approaches would have caught this earlier. | 21:31:33 |
| infinisil | Philip Taron (UTC-8): At least the new test in the PR should prevent this in the future (though for it to trigger automatically we have to wait for ofborg eval to finish) | 21:32:30 |
| infinisil | I opened some more follow-up work, I won't link everything here though, you can check out the RFC 140 milestone which I always keep up-to-date: https://github.com/NixOS/nixpkgs/milestone/25 | 22:49:43 |
| 18 Jan 2024 |
| infinisil | Just opened https://github.com/NixOS/nixpkgs/pull/281835, this is the final follow-up (for now), which now actually starts enforcing pkgs/by-name! Very small PR due to all the preparatory work :) | 17:57:29 |
| 22 Jan 2024 |
|  Minijackson joined the room. | 17:19:11 |
| Minijackson | hello everyone! I had a question related to the pkgs/by-name RFC. I have a "versioned" package netbox_3_6, netbox_3_5, and an alias netbox which points to the latest one. To remove duplication, we have a generic.nix file that is importable with arguments that differ from version to version. Is this something that I can implement inside pkgs/by-name? The checker is failing for my latest PR | 17:22:48 |
| Minijackson | Thanks for the answer, infinisil x) | 17:25:08 |
| infinisil | Minijackson: Oh I just commented on your PR :) https://github.com/NixOS/nixpkgs/pull/282929#issuecomment-1904468118 | 17:25:10 |
| infinisil | Three minor issues have come up with the enforcement of pkgs/by-name for new packages. The one above with netbox doesn't have a fix yet, but the other two do:
- https://github.com/NixOS/nixpkgs/pull/282707
- https://github.com/NixOS/nixpkgs/pull/283017
| 23:11:03 |
| 23 Jan 2024 |
|  Alexandros Liarokapis joined the room. | 08:36:56 |
