!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture

216 Members
Discussions about Nixpkgs' architecture - https://github.com/NixOS/nixpkgs/labels/architecture47 Servers

Load older messages


SenderMessageTime
10 Jan 2024
@9999years:matrix.org9999yearsoh it's supposed to be a number18:09:39
@9999years:matrix.org9999years this works
NIX_GET_COMPLETIONS=2 nix run nixpkgs#
18:09:48
@infinisil:matrix.orginfinisil I now scheduled the final review and ideal merge of https://github.com/NixOS/nixpkgs/pull/275539 for the upcoming Monday, 2024-01-15 at 17:00 CET (date -d@1705334400). Anybody is free to join! https://meet.jit.si/nixpkgs-architecture 19:07:47
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
I now scheduled the final review and ideal merge of https://github.com/NixOS/nixpkgs/pull/275539 for the upcoming Monday, 2024-01-15 at 17:00 CET (date -d@1705334400). Anybody is free to join! https://meet.jit.si/nixpkgs-architecture
βœ…
19:54:52
@kity:kity.wtfproblemsapologies but i think at the last meeting i attended i said i would be responsible for something... got distracted with many other things, now i'm not sure what i volunteered to do.21:22:15
@infinisil:matrix.orginfinisil problems: https://github.com/nixpkgs-architecture/meetings/blob/master/2023-11-28.md 21:59:55
@kity:kity.wtfproblemsah, okay22:09:40
@infinisil:matrix.orginfinisilhttps://discourse.nixos.org/t/ci-will-soon-enforce-pkgs-by-name-for-new-packages/3809822:29:39
11 Jan 2024
@kaction:envs.netkactionHello. I as promised, I created pre-RFC about feature parameter names. https://discourse.nixos.org/t/pre-rfc-standardization-of-feature-parameters/3810403:45:24
13 Jan 2024
@9999years:matrix.org9999years added some customization options to writeShellApplication, would appreciate a review
https://github.com/NixOS/nixpkgs/pull/280592
00:53:31
15 Jan 2024
@infinisil:matrix.orginfinisilReminder that we'll have the final review & merge party for https://github.com/NixOS/nixpkgs/pull/275539 in 20 minutes in https://meet.jit.si/nixpkgs-architecture!15:38:58
@Ericson2314:matrix.orgJohn Ericson:)15:59:33
@Ericson2314:matrix.orgJohn Ericsonfinally gonna make it15:59:36
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Joining? 16:02:47
@infinisil:matrix.orginfinisil Robert Hensing (roberth): It's on my side, hopefully should be fixed in a bit, stay tight! 16:49:05
@infinisil:matrix.orginfinisilI'll rejoin when it's good again16:49:17
@Ericson2314:matrix.orgJohn Ericsonhttps://doc.rust-lang.org/std/macro.file.html17:04:48
@infinisil:matrix.orginfinisilTests now fixed, I'll merge once ofborg is happy!17:51:57
@rick:matrix.ciphernetics.nl@rick:matrix.ciphernetics.nlπŸ™ŒπŸΌπŸŽ‰πŸŽ‰17:52:32
16 Jan 2024
@infinisil:matrix.orginfinisilBad news, there's another problem with the PR, one that would break all CI runs when the channel updates in a couple days πŸ˜…17:07:24
@infinisil:matrix.orginfinisilWorking on both a fix but also future prevention of this, will follow up later17:08:13
@infinisil:matrix.orginfinisilhttps://github.com/NixOS/nixpkgs/pull/28137418:51:07
@infinisil:matrix.orginfinisilThis should be merged relatively quickly ^ I'll definitely merge this myself in like the next 6 hours to prevent master from breaking when the next nixos-unstable channel happens (well, the next next update, not the immediately next one)18:53:10
@infinisil:matrix.orginfinisilAnd here's the problem and fix: https://github.com/NixOS/nixpkgs/pull/281390 (this is not urgent)20:36:31
@infinisil:matrix.orginfinisil
In reply to @infinisil:matrix.org
https://github.com/NixOS/nixpkgs/pull/281374
Now merged, thanks for all the accepting eyes on it!
21:01:36
@infinisil:matrix.orginfinisil
In reply to @infinisil:matrix.org
And here's the problem and fix: https://github.com/NixOS/nixpkgs/pull/281390 (this is not urgent)
We don't need to rush this, but it's a small PR and it contains the fix without which we can't proceed to make pkgs/by-name required for new packages. Reviews appreciated :)
21:02:57
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
We don't need to rush this, but it's a small PR and it contains the fix without which we can't proceed to make pkgs/by-name required for new packages. Reviews appreciated :)
Done. Not much to say, other than a wonder about what approaches would have caught this earlier.
21:31:33
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): At least the new test in the PR should prevent this in the future (though for it to trigger automatically we have to wait for ofborg eval to finish) 21:32:30
@infinisil:matrix.orginfinisilI opened some more follow-up work, I won't link everything here though, you can check out the RFC 140 milestone which I always keep up-to-date: https://github.com/NixOS/nixpkgs/milestone/2522:49:43
18 Jan 2024
@infinisil:matrix.orginfinisil Just opened https://github.com/NixOS/nixpkgs/pull/281835, this is the final follow-up (for now), which now actually starts enforcing pkgs/by-name! Very small PR due to all the preparatory work :) 17:57:29

Show newer messages


Back to Room ListRoom Version: 9