!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

227 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
27 Mar 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8)Others: https://ast-grep.github.io/18:48:26
@philiptaron:matrix.orgPhilip Taron (UTC-8)And https://comby.dev/18:58:19
29 Mar 2024
@sebtm:lodere.esSebTM joined the room.04:24:35
31 Mar 2024
@federicodschonborn:matrix.org@federicodschonborn:matrix.org Not sure if this is the correct place to ask but I have noticed that the by-name check runs even when only adding new comments to the PR, does it really need to? 01:02:53
@federicodschonborn:matrix.org@federicodschonborn:matrix.org * Not sure if this is the correct place to ask but I have noticed that the by-name check runs even when only adding new comments to a PR, does it really need to? 01:03:06
@federicodschonborn:matrix.org@federicodschonborn:matrix.org Or at least the loading indicator is active, I'm not sure if it is actually running 01:04:31
@federicodschonborn:matrix.org@federicodschonborn:matrix.org * Or at least the loading indicator shows up, I'm not sure if it is actually running 01:04:39
@infinisil:matrix.orginfinisil Federico Damián Schonborn See https://github.com/NixOS/nixpkgs/blob/fd387e61dbd83166bc872af87e433166f42fd25b/.github/workflows/check-by-name.yml#L10-L16
I don't think adding comments should trigger it
14:43:11
1 Apr 2024
@infinisil:matrix.orginfinisil No office hour today! 14:49:18
3 Apr 2024
@gerrt:matrix.orggerrt joined the room.18:07:08
@phileas:asra.gr@phileas:asra.gr joined the room.22:41:25
4 Apr 2024
@stablejoy:matrix.org@stablejoy:matrix.org joined the room.06:10:10
@fabaff:matrix.orgfabaff changed their display name from Fabian Affolter to fabaff.08:40:40
@adam:robins.wtf@adam:robins.wtfpardon if this was addressed in the by-name RFC, but was it every considered to have a packages.nix that could allow by-name to support multiple packages in a single directory? i'm still thinking over multi package support15:25:02
@infinisil:matrix.orginfinisil adamcstephens 🐝: Considered yes, but not thought out. Rather deferred for the future to keep it as small as possible for now 15:31:59
5 Apr 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8) infinisil: what do you think about having a function.nix indicate that what ought to exist in the by-name directory is a function, not a derivation? 16:00:02
@philiptaron:matrix.orgPhilip Taron (UTC-8) * infinisil: what do you think about having a file named function.nix indicate that what ought to exist in the by-name directory is a function, not a derivation? 16:00:13
@piegames:matrix.org@piegames:matrix.org
In reply to @philiptaron:matrix.org
infinisil: what do you think about having a file named function.nix indicate that what ought to exist in the by-name directory is a function, not a derivation?
I think this was initially attempted by the RFC
16:02:14
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @piegames:matrix.org
I think this was initially attempted by the RFC
I see https://github.com/nixpkgs-architecture/simple-package-paths/pull/34 which is where the restriction to just derivations is introduced, but I don't see a lot of justification for why nix-build -A name always builds is there.
16:11:46
@yaqueen:matrix.org@yaqueen:matrix.org joined the room.20:35:04
8 Apr 2024
@infinisil:matrix.orginfinisilPersonal office hour now: https://meet.jit.si/nixpkgs-architecture18:00:06
@infinisil:matrix.orginfinisil
In reply to @philiptaron:matrix.org
infinisil: what do you think about having a file named function.nix indicate that what ought to exist in the by-name directory is a function, not a derivation?
I don't think this was discussed actually. Personally I think we should have a clearer separation of derivations vs e.g. derivation-builders
18:01:49
@infinisil:matrix.orginfinisil Dominic Mills: See you around, thanks for joining! 19:53:41
9 Apr 2024
@willbush:matrix.orgwillbush I would have come, but I was viewing the eclipse that happened in the US. 😎 infinisil could you check out https://github.com/NixOS/nixpkgs/pull/302218. I was wondering if we could limit how often the actions? 01:40:47
@ss:someonex.netSomeoneSerge (back on matrix) changed their display name from SomeoneSerge (migrating synapse) to SomeoneSerge (void).13:24:41
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
I don't think this was discussed actually. Personally I think we should have a clearer separation of derivations vs e.g. derivation-builders
What would that cleaner separation look like?
19:04:32
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Something like inherit (import <nixpkgs/api> {}) packageSets builders lib nixos ci; 19:13:12
@philiptaron:matrix.orgPhilip Taron (UTC-8) But it wouldn't extend to what's passed in to callPackage-style files, though. 19:13:48
@philiptaron:matrix.orgPhilip Taron (UTC-8) So lib would be passed in, substitute would be passed in, cargo would be passed in, even though one's a "module", ones a function generating a derivation, and one is a derivation 19:14:30
@infinisil:matrix.orginfinisilAh I see, I think this should be done too ideally!19:15:07

Show newer messages


Back to Room ListRoom Version: 9