| 20 Mar 2024 |
infinisil | (context: https://matrix.to/#/!RROtHmAaQIkiJzJZZE:nixos.org/$TgaZeLfUQ7rNQSwa93nXpK06rUPKQ7hK2dl_m_O4tOA?via=nixos.org&via=matrix.org&via=nixos.dev) | 22:58:03 |
infinisil |
reverting to the original build process, that used the newly built nixpkgs-check-by-name as the source for the check
Philip Taron (UTC-8) What do you mean by that?
| 22:58:23 |
infinisil | Currently, the /nix/store path is pinned here, which allows CI to fetch it directly from Hydra here | 23:00:10 |
Philip Taron (UTC-8) | In check-by-name.yml, there's a pinned version of nixpkgs-check-by-name. | 23:00:18 |
Philip Taron (UTC-8) | Yeah | 23:00:20 |
Philip Taron (UTC-8) | * Yeah, exactly. | 23:00:24 |
infinisil | Oh you mean to not do the pinning anymore? | 23:00:55 |
infinisil | Oh right you said that | 23:01:04 |
Philip Taron (UTC-8) | Yes. The version in nixpkgs is the pinned version. | 23:01:10 |
Philip Taron (UTC-8) | And hence cached and build however is right for running in nixpkgs CI! | 23:01:37 |
Philip Taron (UTC-8) | Can absolutely be static if need be. | 23:01:49 |
infinisil | That's problematic for PRs that change dependencies of the tool and would take a long time to build | 23:02:15 |
infinisil | I think the pinning is very necessary, see https://github.com/NixOS/nixpkgs/pull/281374 | 23:02:23 |
infinisil | Well not sure if that's the right thing to link to actually | 23:03:04 |