!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

227 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
18 Mar 2024
@infinisil:matrix.orginfinisil willbush: Alright, thanks for joining :D 20:30:25
@willbush:matrix.orgwillbushI was going to say https://github.com/dandavison/delta is what I was actually thinking of20:30:29
@willbush:matrix.orgwillbushNo problem. Thanks for having me!20:30:50
@infinisil:matrix.orginfinisilAh neat, might try it out too :D20:30:55
@infinisil:matrix.orginfinisil For everybody's interest: The nixpkgs-check-by-name code is being moved to a separate repository: https://github.com/NixOS/nixpkgs/issues/286559#issuecomment-2005161782 22:43:30
@infinisil:matrix.orginfinisilI'll be a bit more loose with the PRs there, especially because they won't have a direct influence on Nixpkgs22:44:52
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): I gave you write access since you've been so helpful with the reviews of it before the move already, so you can merge my PRs if you want, the first one being https://github.com/NixOS/nixpkgs-check-by-name/pull/1 22:46:00
@philiptaron:matrix.orgPhilip Taron (UTC-8)👍️22:46:21
@philiptaron:matrix.orgPhilip Taron (UTC-8)Would you be opposed to me adding a flake? I can make it integrate with the default.nix you have in PR #1.22:48:58
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Nope :) 23:27:59
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Separate PR though? 23:28:11
@philiptaron:matrix.orgPhilip Taron (UTC-8)Of course.23:28:17
@philiptaron:matrix.orgPhilip Taron (UTC-8)Try rebasing PR #923:28:43
@philiptaron:matrix.orgPhilip Taron (UTC-8)Hrm. No workflows ran.23:29:44
@philiptaron:matrix.orgPhilip Taron (UTC-8)There we go.23:30:40
@philiptaron:matrix.orgPhilip Taron (UTC-8)My brain completely yadda-yadda-yadda'd "master" vs. "main" difference23:31:09
@infinisil:matrix.orginfinisil:P23:33:27
@philiptaron:matrix.orgPhilip Taron (UTC-8)2min run... not great, not bad.23:34:05
@infinisil:matrix.orginfinisilI guess a lot of it comes from it fetching the dependencies for the shell23:34:42
@infinisil:matrix.orginfinisilMaybe we could just not build the shell in CI, probably not necessary23:35:03
@philiptaron:matrix.orgPhilip Taron (UTC-8) That's why I like the detsys magic cache that puts the stuff needed to build into the GitHub action cache 23:38:13
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): In this case I'm not sure if it'll help, since effectively everything is cached already by cache.nixos.org 23:39:28
@willbush:matrix.orgwillbush
In reply to @philiptaron:matrix.org
That's why I like the detsys magic cache that puts the stuff needed to build into the GitHub action cache
I remember seeing that before and forgot to try it out
23:39:57
@philiptaron:matrix.orgPhilip Taron (UTC-8)I usually found that it's like 40% faster even if that's the case. ymmv23:39:59
@infinisil:matrix.orginfinisilAhh yeah I could see that23:40:15
@infinisil:matrix.orginfinisilFeel free to try!23:40:22
@philiptaron:matrix.orgPhilip Taron (UTC-8)locality is a hell of a drug23:40:24
@philiptaron:matrix.orgPhilip Taron (UTC-8)will do23:40:27
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @philiptaron:matrix.org
2min run... not great, not bad.
again, not bad though
23:40:41
@infinisil:matrix.orginfinisilYeah, could be much worse23:44:11

Show newer messages


Back to Room ListRoom Version: 9