!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

232 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
20 Feb 2024
@k900:0upti.meK900Without having to fight all-packages.nix merge conflicts for months20:36:59
@Minijackson:matrix.orgMinijackson note that weirdly enough, splicing is a solution to the flake packages.${arch} issue: https://github.com/szlend/nix-pkgset 20:37:02
@szlend:matrix.orgszlendYeah, this is just me trying to follow whatever patterns are established by nixpkgs because I didn't feel like reinventing the wheel20:37:39
@k900:0upti.meK900It's not20:37:44
@k900:0upti.meK900Well it kinda is20:37:51
@k900:0upti.meK900But it's still a hack20:37:55
@k900:0upti.meK900I have ideas but that's a conversation for much later20:38:06
26 Feb 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8) infinisil: I'm on deck to take a look through your by-name PR today. It's hefty! 17:27:46
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Thanks and agreed! 17:29:10
@philiptaron:matrix.orgPhilip Taron (UTC-8)At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PRs.17:30:02
@philiptaron:matrix.orgPhilip Taron (UTC-8) * At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PR.17:30:04
@infinisil:matrix.orginfinisilI should create smaller PRs than this really 😅17:30:42
@infinisil:matrix.orginfinisilThough if I do small PRs in parallel, I'd get a ton of merge conflicts. And if I do them in series, it would take a long time to make any progress17:31:38
@infinisil:matrix.orginfinisilSome middle ground is probably best17:32:17
@philiptaron:matrix.orgPhilip Taron (UTC-8)Yeah; I think the PR size is OK iff the reviewer can say yes/no on each commit.17:33:56
@philiptaron:matrix.orgPhilip Taron (UTC-8)That powers you to make targeted fixes on each commit, which makes the merge conflicts lower, which enhances the whole PR, in my experience.17:34:41
@infinisil:matrix.orginfinisilOh yeah that sounds nice17:35:02
@philiptaron:matrix.orgPhilip Taron (UTC-8)But since we're in "default GitHub" world, we must make do.17:35:05
@philiptaron:matrix.orgPhilip Taron (UTC-8)It's OK.17:35:07
@infinisil:matrix.orginfinisilGotta work with the tools you have!17:35:47
@infinisil:matrix.orginfinisil(up to a point!)17:35:52
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @infinisil:matrix.org
Gotta work with the tools you have!
Did the work, PR reviewed. Biggest blocker is the non-reproducibility of the tests since they encode /home/tweagysil/src, then lots of English wordings and suggestions.
21:04:11
29 Feb 2024
@adam:robins.wtf@adam:robins.wtf joined the room.03:22:59
@2xsaiko:tchncs.de@2xsaiko:tchncs.de joined the room.03:23:03
@nscnt:matrix.org@nscnt:matrix.org joined the room.07:07:56
@zimbatm:numtide.comJonas Chevalier joined the room.14:56:35
1 Mar 2024
@tomberek:matrix.orgtomberek set a profile picture.15:20:36
2 Mar 2024
@dooy:matrix.org@dooy:matrix.org left the room.11:27:53
@qyriad:katesiria.orgQyriad joined the room.19:34:26
5 Mar 2024
@infinisil:matrix.orginfinisil @room Meeting now (meeting link, meeting notes. We didn't really reach consensus last time, but I do finally think that we can call this the final meeting. 14:00:40

Show newer messages


Back to Room ListRoom Version: 9