!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

228 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
8 Jan 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8)Perfect. I'll get you a normal comment first in case today is overcome by events. :-)16:38:35
@philiptaron:matrix.orgPhilip Taron (UTC-8)Delivered.16:39:14
@infinisil:matrix.orginfinisilThanks a lot!16:42:48
9 Jan 2024
@infinisil:matrix.orginfinisil @room: The next meeting will take place in a couple minutes - meeting link - meeting notes 13:57:10
@infinisil:matrix.orginfinisil tomberek: Robert Hensing (roberth): growpotkin ( Alex Ameen ): John Ericson: Ping? 14:04:56
@growpotkin:matrix.orgGrowpotkinI can't make it. I'm probably having a baby today!! 🎉 14:05:30
@infinisil:matrix.orginfinisil Growpotkin: Oh concrats! 14:05:53
@Ericson2314:matrix.orgJohn Ericsongah I am cursed with this law, was unable to sleep most the night and then finally fell asleep through this15:23:52
@Ericson2314:matrix.orgJohn Ericsonhttps://github.com/NixOS/nixpkgs/pull/278805 still unmerged?15:24:18
@infinisil:matrix.orginfinisil John Ericson: I'll merge it once I addressed the feedback :) 15:33:46
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Just addressed your feedback in https://github.com/NixOS/nixpkgs/pull/278805 :) 18:42:37
@infinisil:matrix.orginfinisilWasn't sure about one thing, but since it's not blocking anyways I'll merge soon!18:43:35
@philiptaron:matrix.orgPhilip Taron (UTC-8) I'm reviewing https://github.com/NixOS/nixpkgs/pull/275539, infinisil . I accidentally clicked the single comment button. 22:06:04
@infinisil:matrix.orginfinisilThought so, np :D22:06:54
@philiptaron:matrix.orgPhilip Taron (UTC-8)Want to run the rfc101 formatter on those test files?22:09:45
@philiptaron:matrix.orgPhilip Taron (UTC-8)

Copy-editing:

This should not be necessary, please move the package back and remove the manual callPackage.

Comma splice; remove the comma and replace it with either a period or semicolon.

22:11:19
@philiptaron:matrix.orgPhilip Taron (UTC-8) infinisil: reviewed, ✅ 22:29:13
@infinisil:matrix.orginfinisil
In reply to @philiptaron:matrix.org
Want to run the rfc101 formatter on those test files?
I'm not gonna bother since we're still changing it all the time :P
22:31:45
@philiptaron:matrix.orgPhilip Taron (UTC-8)The formatter, I hope, not the test files!22:32:04
@infinisil:matrix.orginfinisilHaha indeed, just the formatter22:32:25
@philiptaron:matrix.orgPhilip Taron (UTC-8)At work, we have a guideline against "big enums" of the sort that NixpkgsProblem is: we prefer the variant that encapsulates each one of the various "inner" arms as an actual struct or type in itself. The core reason is that this lets us implement and break apart those huge multi-concern files into smaller implementations. I'm definitely not fussed by NixpkgsProblem though.22:39:19
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Oh yeah, I think for now it's fine, but if the tool becomes e.g. more generic (handling all of Nixpkgs) or the much more complex, this could be revisited 22:41:17
@infinisil:matrix.orginfinisilEspecially if more people work on it at the same time22:41:32
@infinisil:matrix.orginfinisil * Philip Taron (UTC-8): Oh yeah, I think for now it's fine, but if the tool becomes e.g. more generic (handling all of Nixpkgs) or much more complex, this could be revisited 22:41:53
@philiptaron:matrix.orgPhilip Taron (UTC-8)As currently structured it's a recipe for merge conflicts, for sure.22:41:54
@philiptaron:matrix.orgPhilip Taron (UTC-8)See the Rust folks talking about this issue: https://github.com/rust-lang/lang-team/issues/122#issuecomment-96445976922:43:15
10 Jan 2024
@9999years:matrix.org9999years

Nix has a namespace problem.
Versions? They go in the name sometimes, like python2. Names aren't consistent everywhere, either. The name of a package in all-packages.nix might need to be different from the name in its own derivation source. Good luck finding it.

Not every package gets a global name, either. Some are moved into separate attributes sets. Some get both.

https://news.ycombinator.com/item?id=38933136

17:45:42
@9999years:matrix.org9999years ^^ i've long wished for a generated list of every 'public' nixpkgs attribute. it really sucks that there's no better way to find package names than reading the source or guessing and praying. the manual lists a few of the special cases like pythonPackages, but there's lots of stuff that's kinda weird and less documented than it should be (like is there a difference between python.pkgs and pythonPackages? no clue) 17:48:42
@k900:0upti.meK900search.nixos.org is that?17:49:39
@k900:0upti.meK900Except a few attrsets that are explicitly included17:49:46

Show newer messages


Back to Room ListRoom Version: 9