| 8 Jan 2024 |
 infinisil | A normal comment < a comment with a suggestion < a PR | 16:37:42 |
 Philip Taron (UTC-8) | Perfect. I'll get you a normal comment first in case today is overcome by events. :-) | 16:38:35 |
| Philip Taron (UTC-8) | Delivered. | 16:39:14 |
| infinisil | Thanks a lot! | 16:42:48 |
| 9 Jan 2024 |
| infinisil | @room: The next meeting will take place in a couple minutes - meeting link - meeting notes | 13:57:10 |
| infinisil | tomberek: Robert Hensing (roberth): growpotkin ( Alex Ameen ): John Ericson: Ping? | 14:04:56 |
 Growpotkin | I can't make it. I'm probably having a baby today!! 🎉 | 14:05:30 |
| infinisil | Growpotkin: Oh concrats! | 14:05:53 |
 John Ericson | gah I am cursed with this law, was unable to sleep most the night and then finally fell asleep through this | 15:23:52 |
| John Ericson | https://github.com/NixOS/nixpkgs/pull/278805 still unmerged? | 15:24:18 |
| infinisil | John Ericson: I'll merge it once I addressed the feedback :) | 15:33:46 |
| infinisil | Philip Taron (UTC-8): Just addressed your feedback in https://github.com/NixOS/nixpkgs/pull/278805 :) | 18:42:37 |
| infinisil | Wasn't sure about one thing, but since it's not blocking anyways I'll merge soon! | 18:43:35 |
| Philip Taron (UTC-8) | I'm reviewing https://github.com/NixOS/nixpkgs/pull/275539, infinisil . I accidentally clicked the single comment button. | 22:06:04 |
| infinisil | Thought so, np :D | 22:06:54 |
| Philip Taron (UTC-8) | Want to run the rfc101 formatter on those test files? | 22:09:45 |
| Philip Taron (UTC-8) | Copy-editing:
This should not be necessary, please move the package back and remove the manual callPackage.
Comma splice; remove the comma and replace it with either a period or semicolon.
| 22:11:19 |
| Philip Taron (UTC-8) | infinisil: reviewed, ✅ | 22:29:13 |
| infinisil | In reply to @philiptaron:matrix.org
Want to run the rfc101 formatter on those test files? I'm not gonna bother since we're still changing it all the time :P | 22:31:45 |
| Philip Taron (UTC-8) | The formatter, I hope, not the test files! | 22:32:04 |
| infinisil | Haha indeed, just the formatter | 22:32:25 |
| Philip Taron (UTC-8) | At work, we have a guideline against "big enums" of the sort that NixpkgsProblem is: we prefer the variant that encapsulates each one of the various "inner" arms as an actual struct or type in itself. The core reason is that this lets us implement and break apart those huge multi-concern files into smaller implementations.
I'm definitely not fussed by NixpkgsProblem though. | 22:39:19 |
| infinisil | Philip Taron (UTC-8): Oh yeah, I think for now it's fine, but if the tool becomes e.g. more generic (handling all of Nixpkgs) or the much more complex, this could be revisited | 22:41:17 |
| infinisil | Especially if more people work on it at the same time | 22:41:32 |
| infinisil | * Philip Taron (UTC-8): Oh yeah, I think for now it's fine, but if the tool becomes e.g. more generic (handling all of Nixpkgs) or much more complex, this could be revisited | 22:41:53 |
| Philip Taron (UTC-8) | As currently structured it's a recipe for merge conflicts, for sure. | 22:41:54 |
| Philip Taron (UTC-8) | See the Rust folks talking about this issue: https://github.com/rust-lang/lang-team/issues/122#issuecomment-964459769 | 22:43:15 |
| 10 Jan 2024 |
 9999years |
Nix has a namespace problem.
Versions? They go in the name sometimes, like python2. Names aren't consistent everywhere, either. The name of a package in all-packages.nix might need to be different from the name in its own derivation source. Good luck finding it.
Not every package gets a global name, either. Some are moved into separate attributes sets. Some get both.
https://news.ycombinator.com/item?id=38933136
| 17:45:42 |
| 9999years | ^^ i've long wished for a generated list of every 'public' nixpkgs attribute. it really sucks that there's no better way to find package names than reading the source or guessing and praying. the manual lists a few of the special cases like pythonPackages, but there's lots of stuff that's kinda weird and less documented than it should be (like is there a difference between python.pkgs and pythonPackages? no clue) | 17:48:42 |
 K900 | search.nixos.org is that? | 17:49:39 |
