| 8 Jan 2024 |
 infinisil | John Ericson: Thanks! Be aware that there's two PRs. One is just preparing with refactorings, that's the one I'd like to merge tomorrow (https://github.com/NixOS/nixpkgs/pull/278805). The one you reviewed is the one I'd only like to merge in the merge party in ~1-2 weeks :) (https://github.com/NixOS/nixpkgs/pull/275539) | 16:16:37 |
 John Ericson | oh ok :) | 16:20:01 |
| John Ericson | oops! | 16:20:03 |
 Philip Taron (UTC-8) | infinisil: would you be open a couple small commits targeting tweag:by-name-enforce-preparation or would you like to maintain the social lock on this tool? | 16:21:18 |
| Philip Taron (UTC-8) | In particular: switching anyhow::Context::context to with_context so that it doesn't make the error strings in the non-error case | 16:21:56 |
| infinisil | Philip Taron (UTC-8): PRs appreciated! | 16:36:36 |
| infinisil | A normal comment < a comment with a suggestion < a PR | 16:37:42 |
| Philip Taron (UTC-8) | Perfect. I'll get you a normal comment first in case today is overcome by events. :-) | 16:38:35 |
| Philip Taron (UTC-8) | Delivered. | 16:39:14 |
| infinisil | Thanks a lot! | 16:42:48 |
| 9 Jan 2024 |
| infinisil | @room: The next meeting will take place in a couple minutes - meeting link - meeting notes | 13:57:10 |
| infinisil | tomberek: Robert Hensing (roberth): growpotkin ( Alex Ameen ): John Ericson: Ping? | 14:04:56 |
 Growpotkin | I can't make it. I'm probably having a baby today!! 🎉 | 14:05:30 |
| infinisil | Growpotkin: Oh concrats! | 14:05:53 |
| John Ericson | gah I am cursed with this law, was unable to sleep most the night and then finally fell asleep through this | 15:23:52 |
| John Ericson | https://github.com/NixOS/nixpkgs/pull/278805 still unmerged? | 15:24:18 |
| infinisil | John Ericson: I'll merge it once I addressed the feedback :) | 15:33:46 |
| infinisil | Philip Taron (UTC-8): Just addressed your feedback in https://github.com/NixOS/nixpkgs/pull/278805 :) | 18:42:37 |
| infinisil | Wasn't sure about one thing, but since it's not blocking anyways I'll merge soon! | 18:43:35 |
| Philip Taron (UTC-8) | I'm reviewing https://github.com/NixOS/nixpkgs/pull/275539, infinisil . I accidentally clicked the single comment button. | 22:06:04 |
| infinisil | Thought so, np :D | 22:06:54 |
| Philip Taron (UTC-8) | Want to run the rfc101 formatter on those test files? | 22:09:45 |
| Philip Taron (UTC-8) | Copy-editing:
This should not be necessary, please move the package back and remove the manual callPackage.
Comma splice; remove the comma and replace it with either a period or semicolon.
| 22:11:19 |
| Philip Taron (UTC-8) | infinisil: reviewed, ✅ | 22:29:13 |
| infinisil | In reply to @philiptaron:matrix.org
Want to run the rfc101 formatter on those test files? I'm not gonna bother since we're still changing it all the time :P | 22:31:45 |
| Philip Taron (UTC-8) | The formatter, I hope, not the test files! | 22:32:04 |
| infinisil | Haha indeed, just the formatter | 22:32:25 |
| Philip Taron (UTC-8) | At work, we have a guideline against "big enums" of the sort that NixpkgsProblem is: we prefer the variant that encapsulates each one of the various "inner" arms as an actual struct or type in itself. The core reason is that this lets us implement and break apart those huge multi-concern files into smaller implementations.
I'm definitely not fussed by NixpkgsProblem though. | 22:39:19 |
| infinisil | Philip Taron (UTC-8): Oh yeah, I think for now it's fine, but if the tool becomes e.g. more generic (handling all of Nixpkgs) or the much more complex, this could be revisited | 22:41:17 |
| infinisil | Especially if more people work on it at the same time | 22:41:32 |
