| 3 Oct 2023 |
 infinisil | Here's an example of ofborg's performance report: https://github.com/NixOS/nixpkgs/pull/258804/checks?check_run_id=17356593009 | 16:38:34 |
 Robert Hensing (roberth) | ofborg just renders NIX_SHOW_STATS=1, but is not a serious benchmarking tool | 16:39:03 |
 DavHau | Concerning the github issue, should I open one on nixpkgs-architecture? I could also open a WIP PR on nixpkgs, but the thing is based on another WIP branch of robert, therfore not sure. | 16:39:44 |
| Robert Hensing (roberth) |
WIP
That PR might stall for a while until we figure out how to communicate options and other metadata like checks (TBD, infinisil) through all the types
| 16:41:07 |
| Robert Hensing (roberth) | *
WIP
That PR might stall for a while until we figure out how to communicate options and other metadata like checks (TBD, infinisil) through all the composite types
| 16:41:18 |
| Robert Hensing (roberth) | It's fine to include those commits in your PR. It's a point in time kind of thing anyway | 16:42:36 |
|  pbsds changed their profile picture. | 21:04:17 |
| 4 Oct 2023 |
| pbsds changed their profile picture. | 22:20:24 |
| infinisil | Small but nice: https://github.com/NixOS/nixpkgs/pull/259074 | 22:22:24 |
| 5 Oct 2023 |
|  @cafkafk:gitter.im joined the room. | 10:11:38 |
| 6 Oct 2023 |
| infinisil | Merged it myself, it's small enough and I tested it well enough that I felt confident doing that :) | 03:35:32 |
| 9 Oct 2023 |
 Artturin | infinisil: Lol your pkgs/test/nixpkgs-check-by-name/tests/package-nix-dir/pkgs/by-name/fo/foo/package.nix/default.nix pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix tests cause errors in nixpkgs-lint https://github.com/nix-community/nixpkgs-lint/blob/master/src/find.rs | 07:10:19 |
| Artturin | * infinisil: Lol your pkgs/test/nixpkgs-check-by-name/tests/package-nix-dir/pkgs/by-name/fo/foo/package.nix/default.nix pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix tests cause errors in nixpkgs-lint https://github.com/nix-community/nixpkgs-lint/blob/6af572ac6994d9919bcb54578eb8430bcbf1f6e0/src/find.rs | 07:29:33 |
| Artturin | * infinisil: Lol your pkgs/test/nixpkgs-check-by-name/tests/package-nix-dir/pkgs/by-name/fo/foo/package.nix/default.nix pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix tests cause errors in nixpkgs-lint https://github.com/nix-community/nixpkgs-lint/blob/6af572ac6994d9919bcb54578eb8430bcbf1f6e0/src/find.rs
fixed https://github.com/nix-community/nixpkgs-lint/commit/f56d5c4efb3bb3cdb2ab46fda8c598105d6e8af1
| 07:35:04 |
| infinisil | In reply to @artturin:matrix.org
infinisil: Lol your pkgs/test/nixpkgs-check-by-name/tests/package-nix-dir/pkgs/by-name/fo/foo/package.nix/default.nix pkgs/test/nixpkgs-check-by-name/tests/symlink-invalid/pkgs/by-name/fo/foo/foo.nix tests cause errors in nixpkgs-lint https://github.com/nix-community/nixpkgs-lint/blob/6af572ac6994d9919bcb54578eb8430bcbf1f6e0/src/find.rs
fixed https://github.com/nix-community/nixpkgs-lint/commit/f56d5c4efb3bb3cdb2ab46fda8c598105d6e8af1
Haha nice | 07:55:42 |
| 10 Oct 2023 |
| @cafkafk:gitter.im changed their display name from Christina Sørensen to cafkafk. | 03:39:06 |
| @cafkafk:gitter.im changed their profile picture. | 03:39:26 |
| 11 Oct 2023 |
 @piegames:matrix.org | inherit (callPackage ../desktops/gnome/extensions { })
gnomeExtensions
gnome38Extensions
gnome40Extensions
gnome41Extensions
gnome42Extensions
gnome43Extensions
gnome44Extensions
gnome45Extensions
;
I find this a bit silly, since I'm simply inheriting all attributes from the attrset. This is noisy, adds churn and is error-prone.
I know that using something like by-name isn't a thing yet for package sets, but why couldn't I just // (callPackage ../desktops/gnome/extensions { }) to the attrset instead? Much simpler and less pain to maintain
| 14:35:32 |
| infinisil | piegames: That would give you infinite recursion, because the attribute names of an overlay now depends on final | 14:36:15 |
| @piegames:matrix.org | Ah and also as I've recently learned, the above is sub-optimal in the current Nix interpreter, because it will stupidly re-do the callPackage import for every single attribute | 14:36:20 |
| @piegames:matrix.org | In reply to @infinisil:matrix.org
piegames: That would give you infinite recursion, because the attribute names of an overlay now depends on final Um, I don't understand that | 14:36:38 |
| infinisil | piegames: I guess here's a way to show the problem: What if the gnome extensions set defines callPackage = ? | 14:40:02 |
| @piegames:matrix.org | Hm, fair. Can we somehow prevent that with some infrastructure? Some helper function which says "import everything from here into our attrset, and make sure to use super.callPackage to avoid infinite recursion" | 14:42:49 |
| @piegames:matrix.org | On the other hand, shouldn't this still work as long as the package set doesn't define a callPackage? Because stuff is lazy etc. | 14:43:28 |
| @piegames:matrix.org | Well, attribute names are not, but still | 14:43:39 |
| infinisil | Actually lazy attribute sets would allow this: https://github.com/NixOS/nix/issues/4090 | 14:43:59 |
| infinisil | piegames: It can't now whether it defines a callPackage without evaluating it | 14:44:25 |
 tomberek | lazy attrsets... lazy attsets ... lazy attrsets. Or __getter (https://github.com/NixOS/nix/issues/8187#issuecomment-1501258036) or builtins.mkProxy..... or something | 14:45:43 |
| @piegames:matrix.org | Hm, are there any other ways to solve my current problem? | 14:45:53 |
| @piegames:matrix.org | How does by-name work around this? | 14:46:01 |
