!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

229 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
5 Sep 2023
@figsoda:matrix.orgfigsodaI will work on nix-init to support this, hopefully we should see a lot more in the near future19:18:49
@k900:0upti.meK900wa19:19:22
@k900:0upti.meK900Masthead-Waluigi.17345b15.9afde10b.png
Download Masthead-Waluigi.17345b15.9afde10b.png
19:19:34
@figsoda:matrix.orgfigsodaimage.png
Download image.png
19:20:17
@infinisil:matrix.orginfinisil
In reply to @figsoda:matrix.org
I will work on nix-init to support this, hopefully we should see a lot more in the near future
Ah neat! Note that the folder structure should be treated as internal to Nixpkgs, there is no API guarantee that it will not change over time. Considering that, it would be great if we could figure out a proper API that Nixpkgs could expose for this. Maybe it should be as simple as pkgs.preferredDirectoryForPackage "foo" = ./pkgs/by-name/fo/foo
19:22:47
@piegames:matrix.org@piegames:matrix.orgAlso note that there will hopefully be multiple by-names in the future19:23:22
@figsoda:matrix.orgfigsodamy plan is to keep the latest stable release of nix-init compatible with nixpkgs master19:24:54
@figsoda:matrix.orgfigsodaand this should all be easy to opt out so the worst case isn't that bad19:25:36
@infinisil:matrix.orginfinisil Well such an API will happen at some point anyways. It has many more applications. E.g. nix edit could also use it to figure out the file to edit without even having to evaluate anything (meaning it works even if there's a syntax error!) 19:26:52
@infinisil:matrix.orginfinisilAnd position information for packages in general can be known without much evaluation19:27:12
@infinisil:matrix.orginfinisilBut yeah so just be aware that it's all internal to Nixpkgs for now. Any tools built on top of a hardcoded pkgs/by-name will eventually break.19:28:24
@infinisil:matrix.orginfinisil(maybe)19:37:36
6 Sep 2023
@roberthensing:matrix.orgRobert Hensing (roberth)
In reply to @piegames:matrix.org
Also note that there will hopefully be multiple by-names in the future
Or we can upgrade it to top level so that everything about a package can be kept together, which is a nice DX upgrade. ie not just a package but also any modules, documentation, tests, etc.
11:23:55
@piegames:matrix.org@piegames:matrix.org
In reply to @roberthensing:matrix.org
Or we can upgrade it to top level so that everything about a package can be kept together, which is a nice DX upgrade. ie not just a package but also any modules, documentation, tests, etc.
I was thinking more about package sets in their own name spaces
11:29:28
@j-k:matrix.orgj-k

is there any CI that ensures packages are in the right folders? e.g. he/bob/package.nix

also does the pname matter at all?

11:56:15
@j-k:matrix.orgj-k *

is there any CI that ensures packages are in the right folders? e.g. he/bob/package.nix vs bo/bob/package.nix

also does the pname matter at all?

11:56:29
@piegames:matrix.org@piegames:matrix.orgYes and no11:56:58
@roberthensing:matrix.orgRobert Hensing (roberth)
In reply to @piegames:matrix.org
I was thinking more about package sets in their own name spaces
makes sense for say pythonPackages, though I'd omit the actual by-name from the path. Maybe add it to https://github.com/nixpkgs-architecture/issues/issues/21?
12:00:06
@infinisil:matrix.orginfinisil
In reply to @j-k:matrix.org

is there any CI that ensures packages are in the right folders? e.g. he/bob/package.nix vs bo/bob/package.nix

also does the pname matter at all?

Just as piegames said :)
See https://github.com/NixOS/nixpkgs/tree/master/pkgs/by-name#readme for more information
12:02:10
@roberthensing:matrix.orgRobert Hensing (roberth)psa: infinisil has been plotting something12:04:28
@infinisil:matrix.orginfinisilHehe, I think I know what you mean but I'm not 100% certain :P12:06:00
@roberthensing:matrix.orgRobert Hensing (roberth)gotta create some hype for the presentation!12:07:50
@roberthensing:matrix.orgRobert Hensing (roberth)everyone better watch it12:08:09
@davidak:matrix.orgdavidak

is it intentional, that in this place it's called somePackage instead of some-package?

https://github.com/NixOS/nixpkgs/pull/237439/files#diff-a8563497765f3c15777f4e7ebdfa64a8d7ac5fa696f5e1b141bd38545d242a46R70

14:07:15
@roberthensing:matrix.orgRobert Hensing (roberth)the attribute name is derived from it, so it has to match that, not some other convention14:35:49
@roberthensing:matrix.orgRobert Hensing (roberth)I feel like this didn't receive much attention in our communications, or did we14:36:59
@roberthensing:matrix.orgRobert Hensing (roberth)perhaps also worth pointing out that we only require case preservation from the file system, not case sensitivity. We check for that in CI.14:38:43
@infinisil:matrix.orginfinisil Oh but there is a mistake in the docs there. It should be some-package in all cases, thanks for the mention davidak 16:59:39
@infinisil:matrix.orginfinisilWill fix later16:59:43
@infinisil:matrix.orginfinisilhttps://github.com/NixOS/nixpkgs/pull/25366817:30:36

Show newer messages


Back to Room ListRoom Version: 9