| 17 Jul 2023 |
 Ilan Joselevich (Kranzes) | how are you gonna market an RFC that's basically "yeah... so we moved some files around... oh and renamed them I guess?" | 17:39:46 |
 infinisil | The biggest change to Nixpkgs in 20 years | 17:39:51 |
| Ilan Joselevich (Kranzes) | In reply to @infinisil:matrix.org
The biggest change to Nixpkgs in 20 years that's beyond clickbait | 17:40:04 |
| Ilan Joselevich (Kranzes) | even if it might be true | 17:40:11 |
| infinisil | It's actually true, because we'll move about 13000 files | 17:40:30 |
| infinisil | Or, at least I'm like 99.9% sure | 17:40:37 |
| infinisil | (I guess you could consider moving files as no change though) | 17:41:11 |
| Ilan Joselevich (Kranzes) | Yeah but like it doesn't change any actual functionality of what's provided by nixpkgs | 17:41:13 |
 Robert Hensing (roberth) | Move 13000 files? You Won't Believe How Many PRs We'll Break | 17:41:20 |
| Ilan Joselevich (Kranzes) | Does this RFC trigger any builds btw? | 17:42:00 |
| Ilan Joselevich (Kranzes) | * Does this RFC trigger any rebuilds btw? | 17:42:03 |
| infinisil |
Did you get a merge conflict recently? Here's why!
| 17:42:09 |
| infinisil | In reply to @kranzes:matrix.org
Does this RFC trigger any rebuilds btw? Nope, not the first one, nor the second one | 17:42:21 |
| Robert Hensing (roberth) | Technically the installer tests, but those always rebuild out of necessity | 17:43:00 |
| Ilan Joselevich (Kranzes) | In reply to @infinisil:matrix.org
Nope, not the first one, nor the second one So from that perspective, this RFC doesn't do anything 😛 | 17:43:48 |
| Ilan Joselevich (Kranzes) | In reply to @infinisil:matrix.org
Nope, not the first one, nor the second one * So from that perspective, this RFC doesn't change anything 😛 | 17:43:57 |
| infinisil | Touché! | 17:44:52 |
| Ilan Joselevich (Kranzes) | 1 Weird RFC, Contributors Hate Him | 17:45:46 |
| Ilan Joselevich (Kranzes) | * 1 Weird RFC, Contributors Hate Him | 17:45:52 |
| Ilan Joselevich (Kranzes) | Does it actually cause merge conflicts for all new packages PRs? | 17:46:20 |
| infinisil |
Merge conflicts are temporary, improvements last forever
| 17:46:31 |
| infinisil | Ilan Joselevich (Kranzes): Yes, for all PR's that touch moved files, see here | 17:47:34 |
| Ilan Joselevich (Kranzes) | So all PRs that modify all-packages.nix? | 17:48:06 |
| infinisil | Let's not discuss this in this thread :) | 17:49:23 |
| infinisil | Ilan Joselevich (Kranzes): Only the second part of the implementation will cause merge conflicts. And that for all PR's that touch any moved files (changed packages), or PR's that introduce new files (in all-packages.nix) | 17:50:08 |
| infinisil | * Ilan Joselevich (Kranzes): Only the second part of the implementation will cause merge conflicts. And that for all PR's that touch any moved files (changed packages), or PR's that introduce new files (conflict in all-packages.nix very likely) | 17:50:16 |
| infinisil | https://github.com/NixOS/rfcs/blob/master/rfcs/0140-simple-package-paths.md#pr-2-automated-migration | 17:50:37 |
| Ilan Joselevich (Kranzes) | I have to be honest I didn't look too deep into this RFC so I don't remember the stages of it. I do know the overall idea behind the RFC. | 17:51:02 |
| Ilan Joselevich (Kranzes) | Oh nvm, I remember now. | 17:51:33 |
| infinisil | I think it would be good if the title could be easily found later too | 17:55:02 |
