| 9 Jun 2023 |
Robert Hensing (roberth) | I don't think we need to use it much outside the RFC's context | 19:47:28 |
infinisil | "packages by name" sounds pretty good | 19:47:32 |
infinisil | Spelled out pkgs/by-name | 19:47:38 |
infinisil | Hmm, not really a term to use when referring to it though | 19:47:54 |
Robert Hensing (roberth) | "package directory"? | 19:48:12 |
infinisil | That's just pkgs, it's a directory! | 19:48:28 |
Robert Hensing (roberth) | Hmm sounds like that, but not if clearly articulated or written | 19:48:53 |
infinisil | Anyways, yeah it doesn't really matter how we refer to it, if at all | 19:49:01 |
infinisil | I started writing the implementation of the first PR and made sure to not use unit directory in the CI error messages | 19:49:28 |
Robert Hensing (roberth) | Yeah it's not a term people should have to learn | 19:50:05 |
infinisil | If anybody wants to check out the start of the WIP implementation: https://github.com/tweag/nixpkgs/tree/spp-1, I'll create a PR hopefully next week | 19:50:21 |
Robert Hensing (roberth) | Just like how "store dir" is irrelevant to most store users | 19:50:30 |
infinisil | Minor advantage to by-*, it's ordered fairly early, compared to unit which is last :P | 19:52:25 |
infinisil | Considering that we have a potentially better alternative now and more people think unit isn't great, I think that's reason enough to cancel FCP for now, discuss this to completion, then do another FCP once settled. | 19:54:56 |
Robert Hensing (roberth) | Oh looks like I wasn't the first to think of it https://github.com/NixOS/rfcs/pull/140#discussion_r1224642417 | 19:57:27 |
infinisil | By about 30 minutes haha | 19:58:36 |
infinisil | So easy to miss these threads.. | 19:58:56 |
infinisil | Plug for https://github.com/NixOS/rfcs/pull/138 | 19:59:02 |
Robert Hensing (roberth) | In reply to @infinisil:matrix.org Considering that we have a potentially better alternative now and more people think unit isn't great, I think that's reason enough to cancel FCP for now, discuss this to completion, then do another FCP once settled. I feel like FCP should allow a rename to happen without a restart, but maybe I'm wrong | 19:59:10 |
Robert Hensing (roberth) | repos are for suckers who aren't telepathic | 19:59:50 |
Robert Hensing (roberth) | clearly I pulled by-name from someone else's brain without reading anything | 20:00:09 |
infinisil | I wouldn't think so. The naming is an integral part of it, and this potentially better alternative was just talked about for like the past hour, not enough time for the community to take another look at the proposal until FCP ends (tomorrow..) | 20:00:24 |
Robert Hensing (roberth) | Oh right, didn't realise time is that fast. Yeah 1 day is definitely too short | 20:01:03 |
infinisil | Also, I don't really want to have to deal with changing this aspect of the RFC at this hour, and the potential fallout for not canceling FCP for such a change | 20:01:36 |
Robert Hensing (roberth) | Yeah, there's no hurry | 20:01:55 |
infinisil | I'll make a short comment linking to this Matrix thread and that FCP is canceled for now (which I should be allowed to do as the author :P) | 20:02:33 |
K900 | I just want to shout out the fact that the FCP ended up working | 20:05:10 |
K900 | So we are doing something right | 20:05:39 |
@piegames:matrix.org | In reply to @k900:0upti.me I just want to shout out the fact that the FCP ended up working Honestly, I'm not that happy with how it went. Will write something in the meta-RFC Discourse thread tomorrow or so | 20:08:51 |
infinisil | K900: I mean, it ended up with just bikeshedding over one of the simplest aspects of the RFC, while the meat of the RFC was left without any comments 😅 | 20:09:15 |