Nixpkgs Architecture Team | 232 Members | |
| https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture | 53 Servers |
| Sender | Message | Time |
|---|---|---|
| 9 Jun 2023 | ||
| niksnut: Also, in case something you couldn't technically accept for Nix were accepted in an RFC, I expect you to be able to raise "substantial technical objections" (cited from the RFC readme) to prevent such changes from being merged | 17:46:29 | |
| I'm not sure if the peanut gallery is allowed to suggest things, I will promptly delete my message if not, but would sorry in advance if I'm overstepping my bounds here. | 17:58:48 | |
| sy: No problem at all, suggestions are always welcome by anybody! | 17:59:34 | |
| * I'm not sure if the peanut gallery is allowed to suggest things, I will promptly delete my message if not, but would (strictly speaking, I find the idea of sharding for the sake of the GitHub UI to be unfortunate. I think it's weird that we're tying NixOS's design to GitHub's UX.) sorry in advance if I'm overstepping my bounds here. | 18:00:20 | |
| sy: Interesting idea, I can see some minor problems with it:
| 18:02:26 | |
Also I like how any separate pkgs/unit (s/unit/whatever/) allows you to put a Readme.md right in there to explain what it's about, though I think GitHub would also hide the rendered version after the 700 shards.. | 18:04:25 | |
| those are excellent points. I don't personally have anything to add to that but I do agree they are minor. if we had to go the subdirectory route, I would vote on "shards" or "sharded" though I have very little interest in contributing to the naming discussion more than I already have. (I am avoiding pkgs/unit here or pkgs/shards not as a statement but to focus the sharding structure.) regarding GitHub's UI, my only potentially naive rumination on the directory structure is that something like | 18:20:57 | |
| sy: Neat, I don't think we came up with that alternative yet! | 18:23:26 | |
| * those are excellent points. I don't personally have anything to add to that but I do agree they are minor. if we had to go the subdirectory route, I would vote on "shards" or "sharded" though I have very little interest in contributing to the naming discussion more than I already have. (I am avoiding pkgs/unit here or pkgs/shards not as a statement but to focus the sharding structure.) regarding GitHub's UI, my only potentially naive rumination on the directory structure is that something like | 18:23:43 | |
| Btw it's technically a bit more than just 26, because numbers, _ and - are also allowed :P | 18:24:11 | |
| haha. yeah. I ninja edited that change just now. | 18:24:30 | |
I think the biggest argument against such multi-level structures in general is that they cause ambiguities when the package name is too short. E.g. In a pkgs/A/B structure, where would a itself go? | 18:25:27 | |
| There are solutions to this, but it's an extra special case that needs to be explained and implemented. | 18:25:59 | |
However, with only pkgs/A/B, there's only very few packages that would cause such problems, so it's very minor | 18:26:28 | |
| the pkgs/AB/CD is a classical thing BTW | 18:26:54 | |
| oh. that's an excellent point. I guess if we used underscores.. | 18:27:31 | |
| Yeah that was one of the suggested ideas for handling this, using some replacement character | 18:27:52 | |
| * oh. that's an excellent point. I guess if we used underscores.. (or maybe prefix with s?) | 18:28:37 | |
| * oh. that's an excellent point. I guess if we used underscores.. | 18:29:21 | |
How bad of an idea would pkgs/_/AA/BB be | 18:31:31 | |
| K900: The 2-level 2-prefix sharding would lead to most shards containing very few packages (I should measure this a bit better, but it's recorded as an argument in the RFC) | 18:33:23 | |
I mostly mean the _ part | 18:33:56 | |
K900: Using _ is nice and short compared to unit, though it feels like a hack, similar to how you can do let _ = 0; in _ :P | 18:34:03 | |
| I guess it's solving the problem of naming though, because then you don't even have a name anymore lol | 18:34:28 | |
| That's the idea, yeah | 18:36:38 | |
| It's sorted first | 18:36:41 | |
| And it's explicitly not a name | 18:36:43 | |
| And it hopefully looks temporary | 18:36:50 | |
| there were arguments against a temporary name, like that moving things around breaks lots of assumptions about backports and out-of-tree usage | 18:37:29 | |
| Hmm I don't think it should be intended to be temporary. Yes we hope to migrate to something else at some point, but this might also never happen or we completely change the direction. And this is in the scale of perhaps years | 18:38:34 | |