| 19 Mar 2024 |
 Philip Taron (UTC-8) | code velocity ++ | 00:49:47 |
| Philip Taron (UTC-8) | Gotta run to dinner. Good working with you today infinisil . | 00:50:01 |
 infinisil | Philip Taron (UTC-8): Same, have a nice dinner! I'll be sleeping soon 😄 | 00:50:31 |
 fgaz | This kind of system does exist... just not for GH :-/ | 08:40:20 |
| fgaz | For example GitLab, Phorge... | 08:41:30 |
 @jade_:matrix.org | In reply to @fgaz:matrix.org
This kind of system does exist... just not for GH :-/ we need custom stuff anyway | 08:42:44 |
| @jade_:matrix.org | In reply to @jade_:matrix.org
we need custom stuff anyway extracting package metadata from prs and notifying and such | 08:43:07 |
| Philip Taron (UTC-8) | 💯 | 14:56:46 |
| Philip Taron (UTC-8) | It shouldn't be too hard with curl and jq and .timer unit. | 14:57:07 |
| 20 Mar 2024 |
| infinisil | (context: https://matrix.to/#/!RROtHmAaQIkiJzJZZE:nixos.org/$TgaZeLfUQ7rNQSwa93nXpK06rUPKQ7hK2dl_m_O4tOA?via=nixos.org&via=matrix.org&via=nixos.dev) | 22:58:03 |
| infinisil |
reverting to the original build process, that used the newly built nixpkgs-check-by-name as the source for the check
Philip Taron (UTC-8) What do you mean by that?
| 22:58:23 |
| infinisil | Currently, the /nix/store path is pinned here, which allows CI to fetch it directly from Hydra here | 23:00:10 |
| Philip Taron (UTC-8) | In check-by-name.yml, there's a pinned version of nixpkgs-check-by-name. | 23:00:18 |
| Philip Taron (UTC-8) | Yeah | 23:00:20 |
| Philip Taron (UTC-8) | * Yeah, exactly. | 23:00:24 |
| infinisil | Oh you mean to not do the pinning anymore? | 23:00:55 |
| infinisil | Oh right you said that | 23:01:04 |
| Philip Taron (UTC-8) | Yes. The version in nixpkgs is the pinned version. | 23:01:10 |
| Philip Taron (UTC-8) | And hence cached and build however is right for running in nixpkgs CI! | 23:01:37 |
| Philip Taron (UTC-8) | Can absolutely be static if need be. | 23:01:49 |
| infinisil | That's problematic for PRs that change dependencies of the tool and would take a long time to build | 23:02:15 |
| infinisil | I think the pinning is very necessary, see https://github.com/NixOS/nixpkgs/pull/281374 | 23:02:23 |
| infinisil | Well not sure if that's the right thing to link to actually | 23:03:04 |
| Philip Taron (UTC-8) | Yeah, I think that's covered by the move to a separate repo. | 23:03:26 |
| infinisil | Oh it's here: https://github.com/NixOS/nixpkgs/tree/master/pkgs/test/nixpkgs-check-by-name/scripts#update-pinned-toolsh | 23:03:37 |
| infinisil | See the "Why not just build the tooling right from the PRs Nixpkgs version?" part | 23:03:46 |
| Philip Taron (UTC-8) | OK, those are pretty compelling. | 23:04:21 |
| infinisil | Oh what would work is to also pin the Nixpkgs version for the tool | 23:05:14 |
| infinisil | So it's (import pinnedNixpkgs {}).callPackage instead of pkgs.callPackage | 23:05:38 |
| infinisil | Well you'd still need to have it be cached somewhere though.. | 23:06:19 |
