!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

223 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture50 Servers

Load older messages


SenderMessageTime
2 Jan 2025
@error_pro:matrix.orgerror_pro joined the room.10:44:49
8 Jan 2025
@lucasew:matrix.orgLucas Eduardo joined the room.17:36:12
@lucasew:matrix.orgLucas EduardoHello. I am lucasew and I want to eventually get rid of top level withs and implement static checking as a CI step 17:37:10
@lucasew:matrix.orgLucas EduardoActually I did a treewide migration but the PR is too big to be mergeable at once 17:37:35
@lucasew:matrix.orgLucas EduardoAnd I am working on adding the check to nixpkgs-vet 17:37:57
@lucasew:matrix.orgLucas EduardoBut I suck at rust17:38:09
@lucasew:matrix.orgLucas EduardoInfinisil suggested me to create a ratchet rule, I added many tests there already but I can't figure out how to integrate a ratchet which parses nix 17:39:08
@lucasew:matrix.orgLucas EduardoNormal rules I was able to somewhat make it work because most of the logic is there but with ratchet I can't figure out how this dependency injection magic works lol 17:39:46
@lucasew:matrix.orgLucas EduardoFor context, the nixpkgs-vet PR: https://github.com/NixOS/nixpkgs-vet/pull/14217:40:25
@lucasew:matrix.orgLucas EduardoThat's the treewide nixpkgs PR, which I call big chungus, https://github.com/NixOS/nixpkgs/pull/37166517:41:29
@infinisil:matrix.orginfinisil Lucas Eduardo: Wanna do a call right now to try figure it out together? 19:12:01
@lucasew:matrix.orgLucas EduardoRight now I can't. I just finished a few work meetings. 20:16:25
@infinisil:matrix.orginfinisil Lucas Eduardo: I'll push something later for you to look at :) 20:18:22
@infinisil:matrix.orginfinisilhttps://github.com/NixOS/nixpkgs-vet/pull/142#issuecomment-257880270622:45:36
9 Jan 2025
@lucasew:matrix.orgLucas EduardoI was able to do the validation standalone in a simple CLI app 12:20:53
@lucasew:matrix.orgLucas EduardoI linked it on the PR 12:21:04
@lucasew:matrix.orgLucas EduardoNow I just need to integrate it into the PR 12:21:20
@lucasew:matrix.orgLucas EduardoMaybe tweak up a little the message12:21:52
@infinisil:matrix.orginfinisil

@lucasew:matrix.org I hope you saw https://github.com/NixOS/nixpkgs-vet/pull/145#discussion_r1908639140 :)

12:55:32
@lucasew:matrix.orgLucas EduardoI saw it and it will help a lot 12:58:14
@lucasew:matrix.orgLucas EduardoThank you 12:58:16
@lucasew:matrix.orgLucas EduardoI rebased my PR on this but I am having a difficulty in this final part14:35:22
@lucasew:matrix.orgLucas Eduardohttps://github.com/NixOS/nixpkgs-vet/pull/142#discussion_r190892054614:36:13
@lucasew:matrix.orgLucas EduardoI created the comment for the permalink14:36:22
@lucasew:matrix.orgLucas EduardoI think I got it but 15:10:34
@lucasew:matrix.orgLucas EduardoThere is a path issue15:10:43
10 Jan 2025
@lucasew:matrix.orgLucas EduardoWell, the tests are running lol02:34:25
@lucasew:matrix.orgLucas EduardoBut I still think I didnt got it right02:34:36
@lucasew:matrix.orgLucas EduardoMaybe if we move the part of blockage of rules to the problems themselves and then the validators deliver those problems directly then when collecting them we filter for only files or attrsets or stuff like that that had an issue 02:38:13
@lucasew:matrix.orgLucas EduardoIt's happening03:13:40

Show newer messages


Back to Room ListRoom Version: 9