!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

226 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture52 Servers

Load older messages


SenderMessageTime
17 Jul 2023
@kranzes:matrix.orgIlan Joselevich (Kranzes)Yeah but like it doesn't change any actual functionality of what's provided by nixpkgs17:41:13
@roberthensing:matrix.orgRobert Hensing (roberth)Move 13000 files? You Won't Believe How Many PRs We'll Break17:41:20
@kranzes:matrix.orgIlan Joselevich (Kranzes)Does this RFC trigger any builds btw?17:42:00
@kranzes:matrix.orgIlan Joselevich (Kranzes) * Does this RFC trigger any rebuilds btw? 17:42:03
@infinisil:matrix.orginfinisil

Did you get a merge conflict recently? Here's why!

17:42:09
@infinisil:matrix.orginfinisil
In reply to @kranzes:matrix.org
Does this RFC trigger any rebuilds btw?
Nope, not the first one, nor the second one
17:42:21
@roberthensing:matrix.orgRobert Hensing (roberth)Technically the installer tests, but those always rebuild out of necessity17:43:00
@kranzes:matrix.orgIlan Joselevich (Kranzes)
In reply to @infinisil:matrix.org
Nope, not the first one, nor the second one
So from that perspective, this RFC doesn't do anything 😛
17:43:48
@kranzes:matrix.orgIlan Joselevich (Kranzes)
In reply to @infinisil:matrix.org
Nope, not the first one, nor the second one
* So from that perspective, this RFC doesn't change anything 😛
17:43:57
@infinisil:matrix.orginfinisilTouché!17:44:52
@kranzes:matrix.orgIlan Joselevich (Kranzes)1 Weird RFC, Contributors Hate Him17:45:46
@kranzes:matrix.orgIlan Joselevich (Kranzes) * 1 Weird RFC, Contributors Hate Him 17:45:52
@kranzes:matrix.orgIlan Joselevich (Kranzes)Does it actually cause merge conflicts for all new packages PRs?17:46:20
@infinisil:matrix.orginfinisil

Merge conflicts are temporary, improvements last forever

17:46:31
@infinisil:matrix.orginfinisil Ilan Joselevich (Kranzes): Yes, for all PR's that touch moved files, see here 17:47:34
@kranzes:matrix.orgIlan Joselevich (Kranzes)So all PRs that modify all-packages.nix?17:48:06
@infinisil:matrix.orginfinisilLet's not discuss this in this thread :)17:49:23
@infinisil:matrix.orginfinisil Ilan Joselevich (Kranzes): Only the second part of the implementation will cause merge conflicts. And that for all PR's that touch any moved files (changed packages), or PR's that introduce new files (in all-packages.nix) 17:50:08
@infinisil:matrix.orginfinisil * Ilan Joselevich (Kranzes): Only the second part of the implementation will cause merge conflicts. And that for all PR's that touch any moved files (changed packages), or PR's that introduce new files (conflict in all-packages.nix very likely) 17:50:16
@infinisil:matrix.orginfinisilhttps://github.com/NixOS/rfcs/blob/master/rfcs/0140-simple-package-paths.md#pr-2-automated-migration17:50:37
@kranzes:matrix.orgIlan Joselevich (Kranzes)I have to be honest I didn't look too deep into this RFC so I don't remember the stages of it. I do know the overall idea behind the RFC.17:51:02
@kranzes:matrix.orgIlan Joselevich (Kranzes)Oh nvm, I remember now.17:51:33
@infinisil:matrix.orginfinisilI think it would be good if the title could be easily found later too17:55:02
@piegames:matrix.org@piegames:matrix.orgDo multiple choice polls exist?18:00:32
@infinisil:matrix.orginfinisilNope, unfortunately18:00:41
@piegames:matrix.org@piegames:matrix.orgYou could make a yes/no poll for every option :P18:00:56
@piegames:matrix.org@piegames:matrix.orgI miss "all-packages.nix is dead, long live package.nix" as option though18:01:59
@infinisil:matrix.orginfinisilI only added the ones I liked most myself :P18:03:14
@kranzes:matrix.orgIlan Joselevich (Kranzes)Merge conflicts are temporary, improvements are forever! (RFC 140)18:04:07
@kranzes:matrix.orgIlan Joselevich (Kranzes)Is good18:04:09

Show newer messages


Back to Room ListRoom Version: 9