31 Dec 2024 |
| phaer changed their display name from phaer (8650 at 38c3) to phaer. | 19:24:07 |
1 Jan 2025 |
| NixOS Moderation Botchanged room power levels. | 14:26:16 |
2 Jan 2025 |
| Oluwapelumi Adeosun joined the room. | 10:16:23 |
| error_pro joined the room. | 10:44:49 |
8 Jan 2025 |
| Lucas Eduardo joined the room. | 17:36:12 |
Lucas Eduardo | Hello. I am lucasew and I want to eventually get rid of top level withs and implement static checking as a CI step | 17:37:10 |
Lucas Eduardo | Actually I did a treewide migration but the PR is too big to be mergeable at once | 17:37:35 |
Lucas Eduardo | And I am working on adding the check to nixpkgs-vet | 17:37:57 |
Lucas Eduardo | But I suck at rust | 17:38:09 |
Lucas Eduardo | Infinisil suggested me to create a ratchet rule, I added many tests there already but I can't figure out how to integrate a ratchet which parses nix | 17:39:08 |
Lucas Eduardo | Normal rules I was able to somewhat make it work because most of the logic is there but with ratchet I can't figure out how this dependency injection magic works lol | 17:39:46 |
Lucas Eduardo | For context, the nixpkgs-vet PR: https://github.com/NixOS/nixpkgs-vet/pull/142 | 17:40:25 |
Lucas Eduardo | That's the treewide nixpkgs PR, which I call big chungus, https://github.com/NixOS/nixpkgs/pull/371665 | 17:41:29 |
infinisil | Lucas Eduardo: Wanna do a call right now to try figure it out together? | 19:12:01 |
Lucas Eduardo | Right now I can't. I just finished a few work meetings. | 20:16:25 |
infinisil | Lucas Eduardo: I'll push something later for you to look at :) | 20:18:22 |
infinisil | https://github.com/NixOS/nixpkgs-vet/pull/142#issuecomment-2578802706 | 22:45:36 |
9 Jan 2025 |
Lucas Eduardo | I was able to do the validation standalone in a simple CLI app | 12:20:53 |
Lucas Eduardo | I linked it on the PR | 12:21:04 |
Lucas Eduardo | Now I just need to integrate it into the PR | 12:21:20 |
Lucas Eduardo | Maybe tweak up a little the message | 12:21:52 |
infinisil | @lucasew:matrix.org I hope you saw https://github.com/NixOS/nixpkgs-vet/pull/145#discussion_r1908639140 :)
| 12:55:32 |
Lucas Eduardo | I saw it and it will help a lot | 12:58:14 |
Lucas Eduardo | Thank you | 12:58:16 |
Lucas Eduardo | I rebased my PR on this but I am having a difficulty in this final part | 14:35:22 |
Lucas Eduardo | https://github.com/NixOS/nixpkgs-vet/pull/142#discussion_r1908920546 | 14:36:13 |
Lucas Eduardo | I created the comment for the permalink | 14:36:22 |
Lucas Eduardo | I think I got it but | 15:10:34 |
Lucas Eduardo | There is a path issue | 15:10:43 |
10 Jan 2025 |
Lucas Eduardo | Well, the tests are running lol | 02:34:25 |