!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

221 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture54 Servers

Load older messages


SenderMessageTime
26 Jul 2024
@infinisil:matrix.orginfinisilFor others checkin in here, gonna work around it: https://github.com/NixOS/nixpkgs-check-by-name/pull/9023:44:05
@infinisil:matrix.orginfinisil Philip Taron (UTC-8): Oh no, the Cargo.lock is still at 0.1.1, why did this not break anything 😆 23:46:07
@philiptaron:matrix.orgPhilip Taron (UTC-8)Must be some consequence of the cargo update changes??23:48:10
@infinisil:matrix.orginfinisilI noticed it from those: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/10118954269#summary-2798660823023:48:51
@infinisil:matrix.orginfinisilBut like, I'd expect the build itself to fail from this23:49:09
@infinisil:matrix.orginfinisilNot sure what the consequences of a mismatched Cargo.{toml,lock} are23:49:47
@infinisil:matrix.orginfinisil

Philip Taron (UTC-8): I guess I should finish the Changelog PR, because there it would be handled automatically: https://github.com/NixOS/nixpkgs-check-by-name/pull/46/files#diff-d9002f82f23cc9b3c1545ec7d5ddfc3911aec8ba24d4e3d21c73f40355da2a16R85

cargo set-version --manifest-path "$root"/Cargo.toml "$next"

This updates both Cargo.{toml,lock}, without updating anything else :)

23:55:42
27 Jul 2024
@infinisil:matrix.orginfinisil *

Philip Taron (UTC-8): I guess I should finish the Changelog PR, because there it would be handled automatically: https://github.com/NixOS/nixpkgs-check-by-name/pull/46/files#diff-d9002f82f23cc9b3c1545ec7d5ddfc3911aec8ba24d4e3d21c73f40355da2a16R85

cargo set-version --manifest-path "$root"/Cargo.toml "$next"

This updates the version in both Cargo.{toml,lock}, without updating anything else :)

00:05:49
29 Jul 2024
@imincik:matrix.org@imincik:matrix.org left the room.10:01:47
1 Aug 2024
@sigmanificient:matrix.orgSigmanificient joined the room.11:40:49
3 Aug 2024
@reckenrode:matrix.orgRandy Eckenrode joined the room.14:24:05
@reckenrode:matrix.orgRandy Eckenrode

Let me know if I should move this to #dev:nixos.org, but I have a few questions about by-name.

I’m working on the Darwin SDK refactor. As part of that work, I want to move the SDK and source-releases out of os-specific/darwin to the by-name hierarchy. For the SDKs, this is mostly easy. I have a by-name/ap/apple-sdk folder with a package.nix. The source-releases are another matter (see below).

For the SDK, there will be multiple versions. For how to handle those, I can override apple-sdk in all-packages.nix. The question is, do I have to enumerate each versioned SDK package manually in all-packages.nix, or can I do the following?

  inherit (callPackage ../by-name/ap/apple-sdk/all.nix { })
    apple-sdk_10_12 apple-sdk_10_13 apple-sdk_10_14 apple-sdk_10_15
    apple-sdk_11 apple-sdk_12 apple-sdk_13 apple-sdk_14;

For the source-releases, I need a scope. The SDK overrides packages in the scope to the versions it needs for that SDK version (e.g., the 11.3 SDK uses Csu 85 while the 14.4 SDK uses Csu 88). I know things in by-name need to be derivations, but is it keeping in the spirit to passthru a scope? Essentially, I have apple-oss/Csu, add that to a scope, and passthru the scope on the apple-oss derivation. The SDK can then do apple-oss.overrideScope, and things work as expected.

We’ve been talking about various options in #macos:nixos.org. One possibility is keeping it as a package with the other packages not nested (so by-name/ap/apple-oss-Csu, etc). Another is keeping the scope in os-specific/darwin/apple-oss, add it to all-packages.nix, and ignore the check failure in the PR. Not really sure what the best approach would be or what the plan is to handle scopes in by-name (if there is one).

14:24:14
@emilazy:matrix.orgemily (FWIW my proposal was to do by-name/ap/apple-oss-* but have an apple-oss scope defined outside of by-name that just does { Csu = apple-oss-Csu; … } so that the various packages can still depend on apple-oss and get the scope overrides atomically – not sure if that's what Randy meant by "keeping it as a package with the other packages not nested") 14:25:59
@emilazy:matrix.orgemily I do think that it's just wrong for the checker to complain about foo = callPackage ./bar { } if the result of foo is a scope or attrset or something instead of a derivation. (I don't know if it actually does or not, but Randy was worried about it) 14:26:47
@emilazy:matrix.orgemilyunless the intent is that nobody should ever add a top-level scope ever again14:26:56
@reckenrode:matrix.orgRandy Eckenrode I was assuming a by-name/ap/apple-oss that provided a scope, but the packages were packaged separately. I wouldn’t be able to reference a scope defined outside of the SDK. 14:28:10
@reckenrode:matrix.orgRandy Eckenrode I guess I could define the scope in the SDK. That seems like a lot of boilerplate though. 14:28:49
@emilazy:matrix.orgemily I was thinking apple-oss = callPackage ./os-specific/darwin/apple-oss { }; that just provides the scope and re-exports the top-level stuff from pkgs/by-name? 14:29:10
@emilazy:matrix.orgemily which still gets you all the actual new packages being in by-name 14:29:19
6 Aug 2024
@philiptaron:matrix.orgPhilip Taron (UTC-8)
In reply to @emilazy:matrix.org
I do think that it's just wrong for the checker to complain about foo = callPackage ./bar { } if the result of foo is a scope or attrset or something instead of a derivation. (I don't know if it actually does or not, but Randy was worried about it)
It complains if you return anything other than a derivation while putting something in pkgs/by-name: https://github.com/NixOS/nixpkgs-check-by-name/blob/main/src/eval.rs#L316-L321
17:36:34
@philiptaron:matrix.orgPhilip Taron (UTC-8)Here's the branch which controls allowing non-by-name expressions which don't resolve to derivations: https://github.com/NixOS/nixpkgs-check-by-name/blob/main/src/eval.rs#L594-L59617:47:46
8 Aug 2024
@qyliss:fairydust.spaceAlyssa Ross set a profile picture.18:48:35
13 Aug 2024
@out:matrix.org@out:matrix.org joined the room.03:39:45
14 Aug 2024
@fudgemaster:matrix.orgFrank Geusch changed their display name from Master Fudge to Frank Geusch.13:25:53
19 Aug 2024
@alejandrosame:matrix.org@alejandrosame:matrix.org left the room.08:51:41
20 Aug 2024
@benjaminedwardwebb:envs.net@benjaminedwardwebb:envs.net changed their display name from benjaminedwardwebb to benwebb.12:44:13
23 Aug 2024
@infinisil:matrix.orginfinisilNo office hour today unless somebody else wants to join ;)17:57:48
@9999years:matrix.org9999years left the room.18:25:24
@benjaminedwardwebb:envs.net@benjaminedwardwebb:envs.net left the room.19:00:49
24 Aug 2024
@zmitchell:matrix.org@zmitchell:matrix.org left the room.19:43:03

Show newer messages


Back to Room ListRoom Version: 9