| 22 Jul 2024 |
 infinisil | Had to be reverted unfortunately, but this would've been so nice 🥲 | 20:11:51 |
| infinisil | There's a bunch of more recent follow-up PR/issue discussions linked to | 20:12:34 |
| infinisil | * There's a bunch of more recent follow-up PR/issue discussions linked to towards the end | 20:12:40 |
 jeremiahs | In reply to @infinisil:matrix.org
There's a bunch of more recent follow-up PR/issue discussions linked to towards the end reading now | 20:24:44 |
| jeremiahs | infinisil: feel free to correct my understanding, but its not that it cant be done but more work under the hood is required for this to work as expected. | 20:57:54 |
| infinisil | jeremiahs: Hmm, it does work as expected, but it also causes other things to not work as expected :P | 20:59:48 |
| infinisil | I believe a satisfying solution can be figured out, but needs some serious brain power | 21:00:31 |
| jeremiahs | understood | 21:20:59 |
| 23 Jul 2024 |
|  Ezzobir Bezziou joined the room. | 08:22:12 |
|  @felixalb:feal.no left the room. | 11:27:47 |
| 24 Jul 2024 |
|  R̴̨͕͇͍̞̮̐̅͆̌̀̉̐͋̈́̃̀͒́̎̅̚̚̚͠͝Ĕ̵̡̛͖͖̟̙̫̱͈̘̞̭͍͍͑̌̄͑̓̋̓̀̈̏̈́͊̇͊͆̉͂̏̀̃̚͘͝͝ͅͅD̶̡̢͔̱̖̮͙͉̘̺͓͍̩̮͈͍͗̃̀̏͌͘͜ͅŚ̸̬̭̯̬͙͇͓̬̩̳̤͚͓̤̩̺͉͖̉͛̓̿̎͊̿̆́̐͂̇͌̄̇̓͘ͅͅT̴̞̫̘̝͇͔̟̪̪̦͂̔̎̀̎ͅŎ̷̡̬̹̪͈̭̣͈̭̭͉̦̖̝̘̪͖͔̥̦̘̻̳Ṋ̶̛̫͈̳̘͚̜̔̋͆̅̈́͊̑͊̉̌̈́̾͑̈́̚ͅË̸̡̨̨̛͇̜̖͔͖̻̟̗̠̙͓̘̗̥͉͇̜͑͆͊͑͑̀̓͒͜͝͝ changed their display name from redstone-menace to Redstone. | 10:16:19 |
| 25 Jul 2024 |
|  @willpower3309:matrix.org left the room. | 15:09:31 |
 Philip Taron (UTC-8) | I have a set of PRs related to pkgs/top-level/release-attrpaths-superset.nix and the __attrsFailEvaluation attributes sprinkled through nixpkgs. I'd appreciate any reviews and merging.
They're all linked to https://github.com/NixOS/nixpkgs/issues/324619.
| 23:40:23 |
| 26 Jul 2024 |
| infinisil | Philip Taron (UTC-8): Tested and merged, except for the two with merge conflicts :) | 00:07:02 |
| Philip Taron (UTC-8) | Thank you so much!!! | 00:07:29 |
| infinisil | Btw I think a bunch of these could've been done in the same PR with multiple commits, makes it easier to test | 00:07:31 |
| infinisil | I used
for b in $(git branch --remote --list 'philiptaron/__attrsFailEvaluation/*'); do
git merge "$b"
done
| 00:08:03 |
| infinisil | To test all of them together :P | 00:08:08 |
| Philip Taron (UTC-8) | I’m gun shy on that: I’ve gotten so much “I can’t review this” negative feedback on “treewide” changes | 00:08:15 |
| Philip Taron (UTC-8) | They originated as a single branch! | 00:08:33 |
| infinisil | Haha | 00:08:39 |
| infinisil | I see, no worries ;) | 00:08:51 |
| infinisil | I usually want to err on the side of "merge fast and often", which I guess does work better with smaller PRs, but it's hard to strike the balance | 00:10:06 |
| Philip Taron (UTC-8) | Don't I know it. I also like merge fast and often, but, uh, that relies on fast reviews and merges, which are only some of the time present (for obvious open source reasons!) | 00:11:01 |
| infinisil | Yeah 😅 | 00:11:55 |
| infinisil | Philip Taron (UTC-8): Hmm weird, https://github.com/NixOS/nixpkgs-check-by-name/blob/main/.github/workflows/after-release.yml didn't run | 23:29:38 |
| infinisil | https://github.com/NixOS/nixpkgs-check-by-name/actions/workflows/after-release.yml | 23:29:47 |
| Philip Taron (UTC-8) | I saw that. The release went out, though./ | 23:30:09 |
| Philip Taron (UTC-8) | * I saw that. The release went out, though. | 23:30:11 |
| infinisil | It definitely worked before 🤔 https://github.com/NixOS/nixpkgs/pull/303140 | 23:34:26 |
