So @tomberek:matrix.org had pointed me here to talk about an inconsistency I noticed in how nixos handles warnings and assertions. The declaration can be found here: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/misc/assertions.nix

I am wondering if these can be changed to be more consistent. I had a few ideas of a new way it could be done
here is the expected usage:

logs = [
 {
  # if false the build would fail as prior
  assertion = true;
 # if false  it should show a warning as prior
  warnings = true;
  message = "";
  }
];

in the example above we merge the functionality of assertions and warnings into the data structure of which assertions or warnings must be present to be valid. in addition this could be added in a way as to not break the existing module system but nudge towards a more consistent data structure in the module system. let me know if this makes sense or not.

In reply to @infinisil:matrix.org
There's a bunch of more recent follow-up PR/issue discussions linked to towards the end

I have a set of PRs related to pkgs/top-level/release-attrpaths-superset.nix and the __attrsFailEvaluation attributes sprinkled through nixpkgs. I'd appreciate any reviews and merging.

They're all linked to https://github.com/NixOS/nixpkgs/issues/324619.

I used

for b in $(git branch --remote --list 'philiptaron/__attrsFailEvaluation/*'); do
  git merge "$b"
done