| 6 Jul 2024 |
 willbush | Oh I see it's master | 01:05:40 |
| willbush | works on my machine :)
... elided
Running nixpkgs-check-by-name..
Validated successfully
Cleaning up.. Done
| 01:06:52 |
 Philip Taron (UTC-8) | I think it’s got to be something about the version of nix. What version of nix are you running? | 01:10:01 |
| Philip Taron (UTC-8) | I’m on 2.23.1 | 01:10:09 |
| willbush | I'm a bit behind 2.18.2. Tried to update the other day and too much stuff broke. I'm not using openssh so I decided it could wait. | 01:11:40 |
| willbush | I'll give it another go | 01:12:56 |
| willbush | Oh my nix only update to 2.18.4. Just realized there are newer versions available https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=nix | 02:08:04 |
| willbush | Ok now on the same version as you and got the same error:
I/O error: Failed to get the definition info for attribute acl: In /tmp/tmp.M50FW3cBly/merged/pkgs/stdenv/linux/default.nix, attribute parent node is not an attribute path node: NODE_INHERIT@28432..28603
| 02:12:08 |
| Philip Taron (UTC-8) | Got it! Ok, something for a time when I get computer time. Looks like running a test against the nix versions in nixpkgs would be good. Also adding a flag to keep the json output from nix-instantiate? Gotta diff that to see what changed and when. | 16:21:47 |
|  notashelf joined the room. | 22:58:31 |
| notashelf | G'day, I was working on a treewide PR to move packages to by-name & format via nixfmt-rfc-style until I was informed that such PRs are actually discouraged in favor of https://github.com/NixOS/nixpkgs/pull/211832.
Are there any other ongoing processes that I can lend a hand with? Or things I can help speed up by making a series of PRs? Otherwise I plan to go forward with adding licenses to most of the packages listed here but I'd be happy to help with higher-priority issues if there are any.
| 23:17:48 |
| 8 Jul 2024 |
|  @julienmalka:matrix.org left the room. | 10:39:15 |
|  @felixalb:feal.no joined the room. | 16:16:05 |
 infinisil | notashelf: It's a bit tricky unfortunately, but: https://github.com/NixOS/nixpkgs-check-by-name/issues/56 | 17:21:25 |
| infinisil | notashelf: A bit easier is https://github.com/NixOS/nixpkgs/pull/322537, for which it would be best to join #nix-formatting:nixos.org :) | 17:22:16 |
|  @ktemkin:katesiria.org left the room. | 17:35:52 |
 emily | re "Which files are part of a package?", a reasonable start would be just migrating packages that only have default.nix in their directory and nothing else, right? | 17:37:15 |
| infinisil | emily: Good idea, that sounds decent! | 17:59:00 |
| emily | emily@yuyuko ~/D/nixpkgs ((8e484a4c))> ls pkgs/*/*/default.nix | wc -l
965
emily@yuyuko ~/D/nixpkgs ((8e484a4c))> for file in pkgs/*/*/default.nix; test (count (dirname $file)/*) = 1 && echo x; end | wc -l
660
| 18:10:40 |
| emily | that would work for ~68% of packages | 18:10:49 |
| emily | I imagine the rest are mostly divided into "things that vendor something like a Cargo.toml or a few patches" and "things that are going to have to be manually migrated anyway" | 18:11:25 |
| emily | btw, I assume the intention is to get rid of all the "alternative" callPackage/mkDerivation analogues at some point so that everything can be by-name? | 18:24:10 |
| Philip Taron (UTC-8) | callPackage works for a host of things (factories, generators, functions of various sorts) that pkgs/by-name rejects -- in particular, the nixpkgs-check-by-name tool rejects them. | 19:12:58 |
| emily | right; I guess I mean for actual derivations | 19:42:07 |
| emily | like Python or Qt stuff | 19:42:10 |
| emily | (I would certainly be happy to see those go, as they obviously don't compose) | 19:42:30 |
| Philip Taron (UTC-8) | In reply to @philiptaron:matrix.org
When I run maintainers/scripts/check-by-name.sh master locally in my nixpkgs repository, without any changes, I get this error:
I/O error: Failed to get the definition info for attribute acl: In /tmp/tmp.bQmCobXFGj/merged/pkgs/stdenv/linux/default.nix, attribute parent node is not an attribute path node: NODE_INHERIT@28432..28603
Does anyone else reproduce this? It appears to be about this line in pkgs/stdenv/linux/default.nix:
inherit (prevStage)
gzip bzip2 xz bash coreutils diffutils findutils gawk
gnused gnutar gnugrep gnupatch patchelf
attr acl zlib libunistring;
I've opened https://github.com/NixOS/nixpkgs-check-by-name/issues/78 for this issue. Doing some diagnostics now. | 20:20:36 |
| Philip Taron (UTC-8) | And https://github.com/NixOS/nixpkgs-check-by-name/pull/79 now too in order to fix it. CC willbush and infinisil . | 20:45:05 |
 Qyriad | In reply to@emilazy:matrix.org
(I would certainly be happy to see those go, as they obviously don't compose) have you seen the lib.extendMkDerivation PR? | 20:50:55 |
| emily | nope, thanks for the pointer; subscribed | 20:52:12 |
