| 26 Feb 2024 |
 infinisil | Philip Taron (UTC-8): Thanks and agreed! | 17:29:10 |
 Philip Taron (UTC-8) | At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PRs. | 17:30:02 |
| Philip Taron (UTC-8) | * At work, we use a approve-commits model, instead of an approve-PR model, which makes the review process substantially lighter. I'm sad that GitHub doesn't let that happen, since I only get the chance to review the whole squashed PR. | 17:30:04 |
| infinisil | I should create smaller PRs than this really 😅 | 17:30:42 |
| infinisil | Though if I do small PRs in parallel, I'd get a ton of merge conflicts. And if I do them in series, it would take a long time to make any progress | 17:31:38 |
| infinisil | Some middle ground is probably best | 17:32:17 |
| Philip Taron (UTC-8) | Yeah; I think the PR size is OK iff the reviewer can say yes/no on each commit. | 17:33:56 |
| Philip Taron (UTC-8) | That powers you to make targeted fixes on each commit, which makes the merge conflicts lower, which enhances the whole PR, in my experience. | 17:34:41 |
| infinisil | Oh yeah that sounds nice | 17:35:02 |
| Philip Taron (UTC-8) | But since we're in "default GitHub" world, we must make do. | 17:35:05 |
| Philip Taron (UTC-8) | It's OK. | 17:35:07 |
| infinisil | Gotta work with the tools you have! | 17:35:47 |
| infinisil | (up to a point!) | 17:35:52 |
| Philip Taron (UTC-8) | In reply to @infinisil:matrix.org
Gotta work with the tools you have! Did the work, PR reviewed. Biggest blocker is the non-reproducibility of the tests since they encode /home/tweagysil/src, then lots of English wordings and suggestions. | 21:04:11 |
