!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture

217 Members
Discussions about Nixpkgs' architecture - https://github.com/NixOS/nixpkgs/labels/architecture45 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
13 Oct 2023
@infinisil:matrix.orginfinisil

But it did use an updated base branch, just due to how it fetches the merge ref, which github always updates automatically:

  • Before base update: https://github.com/tweag/nixpkgs/actions/runs/6500830578/attempts/1?pr=74#summary-17657001189
  • After base update: https://github.com/tweag/nixpkgs/actions/runs/6500830578?pr=74#summary-17657034351

(note how the stated base branch commit changed)

14:55:13
@roberthensing:matrix.orgRobert Hensing (roberth)unfortunate :/15:59:33
@infinisil:matrix.orginfinisil Hmm but even then it's not perfect, PR's before the introduction of the pkgs/by-name check wouldn't be failing :/ 16:42:26
@infinisil:matrix.orginfinisilAlternative is to somehow force all PR's to be rebased16:42:57
@infinisil:matrix.orginfinisilOr even automatically rebase? No that would mess with GPG signatures16:43:36
@infinisil:matrix.orginfinisilMerging master automatically into each PR? No that would be a super messy history16:43:50
@infinisil:matrix.orginfinisilMaybe it's possible to just kind of associate a new failing check run with PR's that should be rebased16:44:47
@infinisil:matrix.orginfinisilLet me try experimenting with that16:45:18
@infinisil:matrix.orginfinisilAha! This looks pretty good https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-2816:49:02

Show newer messages


Back to Room ListRoom Version: 9