!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

229 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture51 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
12 Sep 2023
@piegames:matrix.org@piegames:matrix.orgThough I'd be interested in some numbers here, like how many pull requests and how many packages are affected by this anyways? How many of these pull requests are younger than three months?10:34:49
@infinisil:matrix.orginfinisilAnd how many PR's will not have to rebase because of this? I guess the turn-over rate is fairly high, just waiting some weeks probably gets a high percentage10:34:56
@profpatsch:augsburg.oneprofpatschpiegames: I had the same idea during nixcon, but honestly I think it’s totally feasible to require PRs to be rebased on top of master10:35:42
@profpatsch:augsburg.oneprofpatschSince that parallelizes well10:35:48
@qyliss:fairydust.spaceAlyssa Rosspresumably we could just use "Rebase and Merge" in the UI, as long as git can tell what's going on? 10:36:13
@profpatsch:augsburg.oneprofpatschofc long feature branches might hate that, but they can merge master back into themselves10:36:24
@qyliss:fairydust.spaceAlyssa Rossmakes the history (and especially bisects) easier too10:36:26
@piegames:matrix.org@piegames:matrix.org
In reply to @qyliss:fairydust.space
presumably we could just use "Rebase and Merge" in the UI, as long as git can tell what's going on?
This would be a deviation from us currently having merge commits everywhere.
10:37:06
@infinisil:matrix.orginfinisilI think the github UI allows either rebasing or merging10:37:29
@qyliss:fairydust.spaceAlyssa Ross we don't currently have merge commits everywhere 10:37:47
@infinisil:matrix.orginfinisil (by default rebase should be good, but as Profpatsch hints at, merging sometimes makes sense) 10:37:55
@qyliss:fairydust.spaceAlyssa Rosswe have a combination of all kinds of merges, based on what each committer thinks is best at the time10:38:12
@piegames:matrix.org@piegames:matrix.orgWhat would be needed here IMO is rebase + merge with trivial merge commit. 10:38:19
@qyliss:fairydust.spaceAlyssa Rossyeah we definitely want merge for e.g. staging-next10:38:21
@qyliss:fairydust.spaceAlyssa Ross what would be the point of the merge commit? 10:38:35

Show newer messages


Back to Room ListRoom Version: 9