!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

234 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture51 Servers

Load older messages


SenderMessageTime
23 Jun 2023
@qyliss:fairydust.spaceAlyssa RossI'm sympathetic to the idea that we should not add warnings to functions that are the only option on stable, but it's certainly not a widespread existing convention.10:34:10
@qyliss:fairydust.spaceAlyssa RossAnd it has downsides for Nixpkgs maintainability — it turns an atomic change into a six month long project. 10:34:35
@qyliss:fairydust.spaceAlyssa RossWhat if we backported the new functions, without a warning?10:35:00
@qyliss:fairydust.spaceAlyssa RossAnd then added the warning on unstable?10:35:07
@qyliss:fairydust.spaceAlyssa RossIt would be a totally valid backport, because it would be entirely additive.10:35:33
@roberthensing:matrix.orgRobert Hensing (roberth)That's still not atomic, so I wouldn't bother with shortening the deprecation window10:36:17
@roberthensing:matrix.orgRobert Hensing (roberth)With the communication skills of an average nixpkgs contributor I wouldn't count on that going well10:37:24
@roberthensing:matrix.orgRobert Hensing (roberth)Good thing we're all above average10:37:29
@qyliss:fairydust.spaceAlyssa RossI don't understand what you're saying10:37:38
@roberthensing:matrix.orgRobert Hensing (roberth)I guess nobody maintains third party packages10:37:51
@qyliss:fairydust.spaceAlyssa RossWhat?10:37:57
@roberthensing:matrix.orgRobert Hensing (roberth)Let's discuss this at a later time10:37:58
@qyliss:fairydust.spaceAlyssa Rossthat might be wise10:38:13
@qyliss:fairydust.spaceAlyssa RossI'll leave a comment on GitHub10:38:13
@roberthensing:matrix.orgRobert Hensing (roberth)Please don't leave a comment on GitHub10:40:16
@qyliss:fairydust.spaceAlyssa Rosstoo late10:40:42
@roberthensing:matrix.orgRobert Hensing (roberth)I'm really sorry about my tone here, but that comment was written with a clear understanding of the problem and I don't want to mudd10:40:45
@roberthensing:matrix.orgRobert Hensing (roberth)aah ok10:40:48
@roberthensing:matrix.orgRobert Hensing (roberth)well10:40:49
@roberthensing:matrix.orgRobert Hensing (roberth)my bad10:40:50
@qyliss:fairydust.spaceAlyssa Rossit'll be okay10:41:00
@roberthensing:matrix.orgRobert Hensing (roberth)yeah that's an ok comment10:41:48
@qyliss:fairydust.spaceAlyssa Ross:)10:41:59
@roberthensing:matrix.orgRobert Hensing (roberth)sorry about the drama. I'm actually really busy today and sometimes I feel a bit too responsible for stuff that happens in nixpkgs10:43:09
@dandellion:dodsorf.asDandellion
In reply to @qyliss:fairydust.space
What if we backported the new functions, without a warning?
That would maybe work in this case, but as a general policy it can't, it'd be unreasonable to always make secondary functions just to to keep the old name clean for 6 months
10:43:51
@qyliss:fairydust.spaceAlyssa Ross I think we all do :) 10:44:17
@roberthensing:matrix.orgRobert Hensing (roberth) For trivial changes we can automate it with lib.isInOldestSupportedRelease (better name suggestions welcome) 10:44:46
@roberthensing:matrix.orgRobert Hensing (roberth)Only for trivial changes though because when we "flip the EOL switch" it creates a bunch of change that should "just work"10:45:23
@roberthensing:matrix.orgRobert Hensing (roberth)Grossly underdocumented btw, which is another reason to have a policy, as that would be a good place to have or link such docs10:46:08
@qyliss:fairydust.spaceAlyssa Ross yeah, this works for when we want to rename a function, not change its behaviour. 10:46:23

Show newer messages


Back to Room ListRoom Version: 9