!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

229 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture51 Servers

Load older messages


SenderMessageTime
16 Jun 2023
@infinisil:matrix.orginfinisil(or anybody really, not just the committee)12:54:51
@phaer:matrix.orgphaeryes, i agree it's nicer to see it right at the top12:55:44
@infinisil:matrix.orginfinisilGitHub doesn't invalidate old reviews when changes were done though, so the old approvals are still visible at the top, but the latest history entry in the PR makes it verifiable :)12:56:52
@sandro:supersandro.deSandroIIRC there is a roadmap ticket to change that13:28:09
@infinisil:matrix.orginfinisil growpotkin ( Alex Ameen ) piegames: I'll be gone in 1.5 hours, but if you both also do a GitHub approving review of https://github.com/NixOS/rfcs/pull/140, you can call for another FCP, we'll probably have to wait until the steering committee meets the next time until it starts though 14:52:54
@infinisil:matrix.orginfinisil * growpotkin ( Alex Ameen ) piegames: I'll be gone in 1.5 hours, but if you both also do a GitHub approving review of https://github.com/NixOS/rfcs/pull/140, you can call for another FCP. We'll probably have to wait until the steering committee meets the next time until it starts though 14:53:15
@piegames:matrix.org@piegames:matrix.org infinisil you need to un-draft the PR first 16:50:59
@piegames:matrix.org@piegames:matrix.orgAlso I'm not sure whether we'll have to wait for the steering committee16:51:21
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
infinisil you need to un-draft the PR first
Ah right. I'm on mobile now though until Monday, and the mobile interface doesn't seem to have an option to mark it as ready 🙃
16:57:23
@infinisil:matrix.orginfinisilAnyways I'll do that next week16:57:31
@piegames:matrix.org@piegames:matrix.orgnoooo16:57:37
@piegames:matrix.org@piegames:matrix.orgAnd if you let the phone render the desktop version?16:57:48
@infinisil:matrix.orginfinisilThis isn't blocking16:57:51
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
And if you let the phone render the desktop version?
I might need by yubikey for 2fa, which I didn't bring of course 🤦‍♂️
16:59:17
@infinisil:matrix.orginfinisilMaybe password works too, I'll try16:59:32
@infinisil:matrix.orginfinisilIt worked yay🎉17:02:09
@infinisil:matrix.orginfinisilWell, with a recovery code, fortunately accessible from my password manager :)17:02:31
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
Also I'm not sure whether we'll have to wait for the steering committee
We could ping them to speed things up maybe
17:03:44
@piegames:matrix.org@piegames:matrix.orgI'll write the announcement17:05:58
@infinisil:matrix.orginfinisil I'll leave it up to you as the de-fact shepherd leader. I think to have to be proper growpotkin ( Alex Ameen ) should accept the RFC again, and the steering committee should do the discourse post again 17:07:41
@infinisil:matrix.orginfinisil piegames: ^ 17:08:13
@piegames:matrix.org@piegames:matrix.org Oh I miscounted the shepherds, so let's wait for growpotkin ( Alex Ameen ) then 17:09:34
@piegames:matrix.org@piegames:matrix.orgAbout the announcement, https://github.com/NixOS/rfcs has been updated in the meantime, and it now says "The FCP is advertised widely by the shepherds, most importantly in the relevant Discourse announcements category." (people said it made more sense that way anyways)17:10:25
@piegames:matrix.org@piegames:matrix.orgWhat it unfortunately doesn't say though, is whether I should make a new post or add a comment to the old one. IMO the latter would be more proper, but not sure.17:11:37
@infinisil:matrix.orginfinisilYeah, but isn't that still the RFC Announcements category which is restricted to the sterring committee?17:12:06
@piegames:matrix.org@piegames:matrix.orgNo that also has been changed in the meantime17:12:22
@infinisil:matrix.orginfinisilOh also the steering committee should add change the RCF label17:12:37
@piegames:matrix.org@piegames:matrix.org Yeah, raitobezarius wanted a bot to do all of this for us for precisely that reason 17:13:21
@raitobezarius:matrix.orgraitobezariussomeday I will get to it17:13:32
@piegames:matrix.org@piegames:matrix.orgI also see merged RFCs which still have the FCP label, same thing17:13:36

Show newer messages


Back to Room ListRoom Version: 9