| 9 Jun 2023 |
Robert Hensing (roberth) | like unit it lends itself to a transposition like by-name/<shard+name>/package. It's really quite similar | 19:18:54 |
infinisil | True that's not bad. I'm not sure if we'd want to keep such a name in a future with more than just packages in these directories though. But that's not a strong argument | 19:21:23 |
Robert Hensing (roberth) | not by-attr because we allow usage that doesn't strictly follow that; all-packages.nix may reuse the path-based name for attributes that have a different name, such as mypkg_unstable and whatnot | 19:22:21 |
infinisil | Hmm, that's not great though, by-name has the same problem | 19:23:26 |
Robert Hensing (roberth) | pkgs/software; just a catch-all category. Even plain data is software according to some definitions | 19:23:39 |
K900 | Also, if I may throw in a nit, it would actually be nice to have it as _by-name or similar | 19:23:48 |
Robert Hensing (roberth) | I think we can add that to the list of considered but rejected quite easily (software) | 19:24:00 |
K900 | So it's sorted first | 19:24:00 |
K900 | Also, I don't think mypkg-unstable breaks by-prefix? | 19:24:16 |
K900 | It is the same prefix after all | 19:24:21 |
K900 | Now unstable-mypkg would | 19:24:35 |
K900 | But that's a different story | 19:24:39 |
infinisil | If we have a single directory containing all the shards then I don't think it needs to be sorted at the beginning. Or at least I wouldn't want to add a _ just for that | 19:24:51 |
Robert Hensing (roberth) | Right, I think in a few cases we might have soft forks with different names though | 19:24:59 |
Robert Hensing (roberth) | Also the other categories will wither away eventually | 19:25:21 |
Robert Hensing (roberth) | I mean pkgs/* subdirs, to the point that there's like five want to keep perhaps | 19:25:42 |
Robert Hensing (roberth) | at that point sorting isn't super relevant | 19:25:48 |
Robert Hensing (roberth) | wouldn't want to be stuck with an underscore then | 19:26:02 |
Robert Hensing (roberth) | What I don't like about by-prefix is that it focuses on the mechanism too much. People will understand it as relating to the two letter shard directories, which is not a useful concept | 19:26:47 |
Robert Hensing (roberth) | I want everyone to think of sharding as a useless but necessary syntax-level concern that really doesn't matter for anything they care about | 19:27:18 |
Robert Hensing (roberth) | Also I want the names that we do use to be meaningful, if at all possible. by-name carries more relevant meaning than by-prefix, because prefixes are a syntax level concern that has no bearing on the actual meaning of what we're declaring in those files | 19:28:37 |
infinisil | Yeah sounds good | 19:28:54 |
infinisil | I'm a bit sad to see unit go, I think it would make a lot of sense going forward, but I agree that something like by-name would be more agreeable | 19:30:55 |
infinisil | In the end I don't think it matters very much though, and I hate to have to discuss this trivial aspect of the RFC so much, this ate away a number of hours today. | 19:32:24 |
infinisil | Also something to consider: If we do move to a more unit-like structure in the future (not just packages), we can still perform the rename then if appropriate pkgs/by-name -> unit` | 19:40:05 |
Robert Hensing (roberth) | Yeah, it doesn't have to be unit for that. Also we can discuss it all over again then :p | 19:41:34 |
Robert Hensing (roberth) |
I'm a bit sad to see unit go
A love/hate relationship here. It was a nice compromise and a reminder of a larger vision, but ultimately too meaningless it seems. It's been a central common ground almost in the team. Maybe Stockholm syndrome? We did discuss naming for a very long time... | 19:43:55 |
infinisil | Robert Hensing (roberth): Are you perhaps already writing a github comment to propose the by-name idea? | 19:45:55 |
Robert Hensing (roberth) | I was thinking to, but then I didn't come up with an actual comment | 19:46:19 |
Robert Hensing (roberth) | I guess a practical downside of by-name is that a "by-name directory" sounds kind of awful | 19:47:01 |