Nixpkgs Architecture Team | 234 Members | |
| https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture | 52 Servers |
| Sender | Message | Time |
|---|---|---|
| 9 Jun 2023 | ||
| Simple as in simple package paths, also simple as in simple to add | 17:31:28 | |
In reply to @k900:0upti.meI think that would imply that there's a complicated way to declare packages, which there currently is, but it's something we should get away from. Once we migrate everything, simple wouldn't mean anything anymore | 17:33:20 | |
| infinisil: The RFC process doesn't replace PR review. And "pkgs/unit" shouldn't get through PR review. | 17:34:17 | |
| so at this time the RFC prefers a meaningless name over one with a meaning | 17:36:00 | |
In reply to @hexa:lossy.networkSome people do, personally I am fine with a meaningless name because any name is better than no name. And so far no satisfactory meaningful name has been brought up IMO | 17:36:52 | |
There's a decent argument for unit by Robert Hensing (roberth) here: https://github.com/NixOS/rfcs/pull/140#discussion_r1170362174 | 17:37:51 | |
In reply to @niksnut:matrix.orgEven if you created Nix, I expect you to respect the community's RFC process, especially for Nixpkgs. If you were to block/revert the implementation of the RFC as it is stated, I consider that a violation of the RFC process. | 17:40:18 | |
| In that case I withdraw my statement about not having to cancel FCP | 17:41:03 | |
| Well, it's up to the shepherd team to decide whether it needs to be canceled | 17:41:33 | |
K900: Oh apparently simple was proposed, see this linked thread | 17:42:58 | |
| For instance, if a shepherd team makes some bad decision about Nix, I wouldn't feel that the Nix team would be required to implement it. That's not how open source works. You can't force maintainers to accept technical decisions that they can't get behind. | 17:43:13 | |
| niksnut: Fully agreed, but in this case it's not Nix, it's Nixpkgs, which is fully developed by the community, there's no official global Nixpkgs maintainers | 17:44:20 | |
| niksnut: Also, in case something you couldn't technically accept for Nix were accepted in an RFC, I expect you to be able to raise "substantial technical objections" (cited from the RFC readme) to prevent such changes from being merged | 17:46:29 | |
| I'm not sure if the peanut gallery is allowed to suggest things, I will promptly delete my message if not, but would sorry in advance if I'm overstepping my bounds here. | 17:58:48 | |
| sy: No problem at all, suggestions are always welcome by anybody! | 17:59:34 | |
| * I'm not sure if the peanut gallery is allowed to suggest things, I will promptly delete my message if not, but would (strictly speaking, I find the idea of sharding for the sake of the GitHub UI to be unfortunate. I think it's weird that we're tying NixOS's design to GitHub's UX.) sorry in advance if I'm overstepping my bounds here. | 18:00:20 | |
| sy: Interesting idea, I can see some minor problems with it:
| 18:02:26 | |
Also I like how any separate pkgs/unit (s/unit/whatever/) allows you to put a Readme.md right in there to explain what it's about, though I think GitHub would also hide the rendered version after the 700 shards.. | 18:04:25 | |
| those are excellent points. I don't personally have anything to add to that but I do agree they are minor. if we had to go the subdirectory route, I would vote on "shards" or "sharded" though I have very little interest in contributing to the naming discussion more than I already have. (I am avoiding pkgs/unit here or pkgs/shards not as a statement but to focus the sharding structure.) regarding GitHub's UI, my only potentially naive rumination on the directory structure is that something like | 18:20:57 | |
| sy: Neat, I don't think we came up with that alternative yet! | 18:23:26 | |
| * those are excellent points. I don't personally have anything to add to that but I do agree they are minor. if we had to go the subdirectory route, I would vote on "shards" or "sharded" though I have very little interest in contributing to the naming discussion more than I already have. (I am avoiding pkgs/unit here or pkgs/shards not as a statement but to focus the sharding structure.) regarding GitHub's UI, my only potentially naive rumination on the directory structure is that something like | 18:23:43 | |
| Btw it's technically a bit more than just 26, because numbers, _ and - are also allowed :P | 18:24:11 | |
| haha. yeah. I ninja edited that change just now. | 18:24:30 | |
I think the biggest argument against such multi-level structures in general is that they cause ambiguities when the package name is too short. E.g. In a pkgs/A/B structure, where would a itself go? | 18:25:27 | |
| There are solutions to this, but it's an extra special case that needs to be explained and implemented. | 18:25:59 | |
However, with only pkgs/A/B, there's only very few packages that would cause such problems, so it's very minor | 18:26:28 | |
| the pkgs/AB/CD is a classical thing BTW | 18:26:54 | |
| oh. that's an excellent point. I guess if we used underscores.. | 18:27:31 | |
| Yeah that was one of the suggested ideas for handling this, using some replacement character | 18:27:52 | |
| * oh. that's an excellent point. I guess if we used underscores.. (or maybe prefix with s?) | 18:28:37 | |