| 29 May 2023 |
 Robert Hensing (roberth) |
This notably doesn't work when name is already a package attribute, because then the default is never used and instead overridden.
| 13:52:07 |
| Robert Hensing (roberth) | or when someone adds a package with that name later | 13:52:17 |
| Robert Hensing (roberth) | hour-letter -> four-letter | 13:55:43 |
| Robert Hensing (roberth) | This would virtually a unlimited number of packages -> This would list? contain? house? | 13:56:31 |
 infinisil | Oh yeah, probably allow | 13:56:59 |
| Robert Hensing (roberth) | Makes a potentially transition -> Makes a potential transition | 13:58:19 |
 @piegames:matrix.org | I'm impressed at how "good" my brain is at overlooking these mistakes, completing the holes without me ever noticing … | 13:58:34 |
| Robert Hensing (roberth) | Yeah I figured I might as well proof-read while I read the thing | 13:58:54 |
| infinisil | Once you're done I'll make a fixup commit with these changes :) | 13:59:38 |
| @piegames:matrix.org | In reply to @roberthensing:matrix.org
Yeah I figured I might as well proof-read while I read the thing My point is, I've done that three times now :( | 14:00:15 |
| Robert Hensing (roberth) | Maybe some of this is new. | 14:00:31 |
| Robert Hensing (roberth) | Most parts are ok, but then a couple of sentences together are messy | 14:00:46 |
| Robert Hensing (roberth) | Maybe I should have bunched these up in a file, but I'm almost done now | 14:01:04 |
| infinisil | Maybe a larger change, I think it was hinted at at some point: Maybe this shouldn't be called a standard when it's Nixpkgs-internal, because people might still be inclined to use it when it's called a standard | 14:01:09 |
| Robert Hensing (roberth) | But then there's a need for a custom argument, which then -> But when the need for a custom argument arises, it then | 14:01:40 |
| infinisil | We only want to standardize it for others to use in the future, then it should be called a standard | 14:01:42 |
| infinisil | * We only want to standardize it for others to use at some point in the future, then it should be called a standard | 14:02:05 |
| Robert Hensing (roberth) | This bullet looks weird: Make the requirement also apply the other way around: Files outside the unit directory cannot access files inside it | 14:02:45 |
| Robert Hensing (roberth) |
Potentially establish an updateScript standard to avoid problems like, relates to Flakes too
??
| 14:04:30 |
| Robert Hensing (roberth) | I think libsForQt5.callPackage is already soft deprecated? But it's probably still an ok example | 14:05:11 |
| Robert Hensing (roberth) |
Alright, that's about it. With those i's dotted, it looks good. Nothing significant, so I'll approve now | 14:06:35 |
 raitobezarius | (apologies I'm on the move, I will reply later to the messages) | 14:15:08 |
| infinisil | Robert Hensing (roberth): Nice thanks :D | 14:16:05 |
| infinisil | In reply to @infinisil:matrix.org
Maybe a larger change, I think it was hinted at at some point: Maybe this shouldn't be called a standard when it's Nixpkgs-internal, because people might still be inclined to use it when it's called a standard While we could do this (along with other things discussed today), I don't think it's necessary, so I'm all good for FCP too | 14:19:02 |
| infinisil | piegames: I think you were intending to write a discourse post to announce FCP right? | 14:19:54 |
| @piegames:matrix.org | The GitHub announcement first, but working on it yes | 14:22:08 |
| infinisil | Sounds good to me, thanks :D | 14:22:50 |
| infinisil | Let's get this to the finish line 🚀 | 14:23:07 |
| @piegames:matrix.org | done | 14:45:39 |
| @piegames:matrix.org | infinisil Maybe please do another pass through the backlog and mark some of the conversation threads as resolved | 14:46:14 |
