| 29 May 2023 |
 infinisil | If so, approving on GitHub would be great, and then we'd have everything for FCP | 13:43:09 |
 Robert Hensing (roberth) | The unit base directory must only contain subdirectories of the form pkgs/unit/${shard}/${name}, | 13:44:12 |
| Robert Hensing (roberth) | technically you're duplicating pkgs/unit, as in pkgs/unit/pkgs/unit, but everyone understand what you mean | 13:44:30 |
| infinisil | Hehe good catch | 13:45:07 |
| Robert Hensing (roberth) | nix-build -E is --expr? | 13:48:12 |
| infinisil | Yeah | 13:48:21 |
| Robert Hensing (roberth) | hm ok | 13:48:25 |
| infinisil | Why does the current nix-build man page not document this flag :/ | 13:48:58 |
| infinisil | Oh right, nix-instantiate is mentioned, and that documents it | 13:49:28 |
| infinisil | Well, barely, it only contains a mention of it.. | 13:49:52 |
| Robert Hensing (roberth) | Improving the arguments, settings infrastructure and docs is an ongoing project | 13:50:03 |
| Robert Hensing (roberth) | A slow project though. We could use some help | 13:50:51 |
| Robert Hensing (roberth) |
This notably doesn't work when name is already a package attribute, because then the default is never used and instead overridden.
| 13:52:07 |
| Robert Hensing (roberth) | or when someone adds a package with that name later | 13:52:17 |
| Robert Hensing (roberth) | hour-letter -> four-letter | 13:55:43 |
| Robert Hensing (roberth) | This would virtually a unlimited number of packages -> This would list? contain? house? | 13:56:31 |
| infinisil | Oh yeah, probably allow | 13:56:59 |
| Robert Hensing (roberth) | Makes a potentially transition -> Makes a potential transition | 13:58:19 |
 @piegames:matrix.org | I'm impressed at how "good" my brain is at overlooking these mistakes, completing the holes without me ever noticing … | 13:58:34 |
| Robert Hensing (roberth) | Yeah I figured I might as well proof-read while I read the thing | 13:58:54 |
| infinisil | Once you're done I'll make a fixup commit with these changes :) | 13:59:38 |
| @piegames:matrix.org | In reply to @roberthensing:matrix.org
Yeah I figured I might as well proof-read while I read the thing My point is, I've done that three times now :( | 14:00:15 |
| Robert Hensing (roberth) | Maybe some of this is new. | 14:00:31 |
| Robert Hensing (roberth) | Most parts are ok, but then a couple of sentences together are messy | 14:00:46 |
| Robert Hensing (roberth) | Maybe I should have bunched these up in a file, but I'm almost done now | 14:01:04 |
| infinisil | Maybe a larger change, I think it was hinted at at some point: Maybe this shouldn't be called a standard when it's Nixpkgs-internal, because people might still be inclined to use it when it's called a standard | 14:01:09 |
| Robert Hensing (roberth) | But then there's a need for a custom argument, which then -> But when the need for a custom argument arises, it then | 14:01:40 |
| infinisil | We only want to standardize it for others to use in the future, then it should be called a standard | 14:01:42 |
| infinisil | * We only want to standardize it for others to use at some point in the future, then it should be called a standard | 14:02:05 |
| Robert Hensing (roberth) | This bullet looks weird: Make the requirement also apply the other way around: Files outside the unit directory cannot access files inside it | 14:02:45 |
