!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

230 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture51 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
29 May 2023
@qyliss:fairydust.spaceAlyssa Rossanyway I need to head out12:05:28
@infinisil:matrix.orginfinisil Or moving the Python core infra into a single directory, instead of it being spread over pkgs/top-level/python-packages.nix, pkgs/interpreters/python and pkgs/python-modules 12:05:28
@infinisil:matrix.orginfinisil Nice discussion though, thanks for the feedback Alyssa Ross 12:05:55
@qyliss:fairydust.spaceAlyssa Rossyeah, thanks12:06:01
@k900:0upti.meK900As someone who regularly makes small changes to random stuff, I would much prefer to not by granularly permission'd12:06:03
@k900:0upti.meK900 Though I do think that having the ability to give people more granular permissions would be very nice 12:06:34
@infinisil:matrix.orginfinisilI think with stronger nixpkgs teams, such that for every part of nixpkgs there's a timely response to proposed changes, this would work much better12:06:55
@k900:0upti.meK900I mean12:07:05
@k900:0upti.meK900"Just fix triage 4head"12:07:14
@infinisil:matrix.orginfinisilHaha12:07:20
@k900:0upti.meK900Like yes but also it's hard12:07:31
@infinisil:matrix.orginfinisilI guess small steps, and this RFC might even be a small step, because I think the NAT is such a team, and just taking ownership over the files implementing the RFC would be very small in scope12:07:55
@infinisil:matrix.orginfinisilLet's not put it into the RFC for now, but that would be a path forward12:08:18
@piegames:matrix.org@piegames:matrix.org
In reply to @infinisil:matrix.org
E.g. the whole idea of separating code into "units", so that the package definition and the NIxOS module are together, would make it easier to give somebody permission to change both at once
Modules and packages don't always map 1:1 unfortunately
12:13:32
@infinisil:matrix.orginfinisil piegames: I'd say this would only be done when they do map 1:1 12:14:06
@infinisil:matrix.orginfinisilWe need another place for modules that aren't specific to any package12:14:30
@piegames:matrix.org@piegames:matrix.org
In reply to @k900:0upti.me
Though I do think that having the ability to give people more granular permissions would be very nice
This is not about removing everyone's general commit access. It's about being able to allow maintainers to merge changes their packages, without having to entrust them with the whole Nixpkgs repository
12:15:42
@raitobezarius:matrix.orgraitobezarius
In reply to @infinisil:matrix.org
Hmm.. I've certainly seen certain committers merge changes to core parts of the code that they didn't really know much about, treating it like any other random package update
But did we teach those committers this was not a good thing, etc. ?
12:24:30
@raitobezarius:matrix.orgraitobezariusI mean before strengthening constraints, I'd love to read a clear motivation and rationale with data on how are we doing on this and what are the set of measures we can put forward to reduce those problems12:25:34
@raitobezarius:matrix.orgraitobezarius
In reply to @infinisil:matrix.org
Same thing when people stop contributing, escalate to ones with more power.
This is not my experience with how nixpkgs does things
12:27:27
@raitobezarius:matrix.orgraitobezariusUsually when people goes AWOL it becomes unmaintained12:27:44
@infinisil:matrix.orginfinisilI haven't explicitly called it out, since in many cases I would've just merged it myself anyways, but I definitely questioned whether the committers actually understood the changes they just made, and whether they would be able to spot a mistake in such changes12:27:50

Show newer messages


Back to Room ListRoom Version: 9