| 29 May 2023 |
 @piegames:matrix.org | * How about "This standard is internal to Nixpkgs and not exposed as public interface , and may be subject to change over time " | 11:31:35 |
| @piegames:matrix.org | * How about "This standard is internal to Nixpkgs and not exposed as public interface , and may be subject to changes in the future " | 11:31:48 |
 infinisil | Since the NAT developed this standard and went through the effort to get it approved with an RFC, I don't think it would be alright for others to make changes to it without also getting it approved by the NAT | 11:33:07 |
| @piegames:matrix.org | I mean, any substantial changes would need a new RFC anyways | 11:33:50 |
| @piegames:matrix.org | I recommend adding yourself as codeowner to related files, so that you can keep track of things that people are doing in that space. | 11:35:04 |
| infinisil | Yeah, I don't think this should be controversial. I expect anybody who wants to make smaller changes to first talk to me and Robert Hensing (roberth) at least. | 11:35:18 |
| infinisil | If the change is not controversial, there won't be a problem. And if the change is controversial, I will complain about it and demand an RFC :P | 11:36:53 |
| @piegames:matrix.org | that's basically my approach, yes | 11:37:49 |
| infinisil | And yeah, code owners for sure, but I'd also like a "needs to be approved by somebody from the NAT before it can be merged". I will try to make it so that the standard's implementation files are separated from anything not involving the standard. | 11:39:54 |
| @piegames:matrix.org | Personally not a fan, but if you really want to then put that into the RFC and see if anybody else complains | 11:41:49 |
 Alyssa Ross | what if the NAT stops existing, or being active? | 11:42:22 |
| Alyssa Ross | it sounds unnecessarily prescriptive given how much ownership evolves in Nixpkgs | 11:42:55 |
| @piegames:matrix.org | Is the NAT one of the "blessed" Nix teams? (I remember seeing some Discourse announcements about making some teams more official entities than others, forgot the wording) | 11:43:22 |
| infinisil | In reply to @qyliss:fairydust.space
what if the NAT stops existing, or being active? Same thing when people stop contributing, escalate to ones with more power. | 11:44:09 |
| Alyssa Ross | but we can't do that if it's in an RFC | 11:44:40 |
| Alyssa Ross | we'd need a whole new RFC | 11:44:46 |
| infinisil | The NAT has existed for a while now already, and I'll make sure that it continues existing, and I trust the other members to continue the NAT in case I happen to have an accident or so. A team is at least much better than a single individual | 11:44:57 |
| Alyssa Ross | we've never had an RFC restrict who can change parts of Nixpkgs before | 11:45:16 |
| Alyssa Ross | nor has any problem that I'm aware of ever come up that suggests such a heavy handed restriction is necessary | 11:45:41 |
| infinisil | I think this is being blown out of proportion | 11:46:42 |
| infinisil | We're talking about situations where: The standard needs a small uncontroversial change, the NAT team does not exist anymore, there's enforced protection of changes to the standard | 11:47:57 |
| Alyssa Ross | RFCs are difficult to change later, so it's really important to get what goes into them right | 11:48:18 |
| infinisil | If the standard is controversial -> RFC; if the NAT does still exist -> just wait for approval; if there's no enforced protection -> just change the files, if the NAT doesn't exist anymore, nobody would complain | 11:48:58 |
| infinisil | And if all three are the case, talk to a NixOS org admin to remove the restriction | 11:49:56 |
| Alyssa Ross | oh I think we might be at crossed wires here | 11:50:08 |
| Alyssa Ross | piegames said "if you really want to then put that into the RFC" | 11:50:22 |
| Alyssa Ross | but I now notice you didn't actually mention putting this in the RFC | 11:50:30 |
| infinisil | In reply to @infinisil:matrix.org
Hmm, how about "This RFC describes the initial standard. The up-to-date standard will be in the Nixpkgs manual. Smaller changes to the standard may be performed by the Nixpkgs Architecture Team without an RFC, while larger changes will need another RFC" Alyssa Ross: This here | 11:50:50 |
| Alyssa Ross | Would "Smaller changes to the standard may be performed without an RFC" work for you? | 11:52:10 |
| @piegames:matrix.org | I'm struggling to imagine any changes that are "minor" in scope yet would be controversial enough to warrant a discussion with the NAT | 11:52:37 |
