!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

233 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
29 May 2023
@piegames:matrix.org@piegames:matrix.org Good. Given that the only remaining discussion point is around the name of the folder, I'd like to go and announce FCP. Before doing that, I'd like to get a go from one of the authors as well (infinisil, Robert Hensing (roberth)) 10:25:17
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
You sure? I can't find the approval of j-k somehow
Oh yeah sorry I must've mixed something up!
10:52:29
@piegames:matrix.org@piegames:matrix.org Also in the FCP announcement I'll mention that the only open discussion point is the name of the folder, and that the currently proposed unit will be kept unless the discussion converges on a different name. 10:54:46
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
Good. Given that the only remaining discussion point is around the name of the folder, I'd like to go and announce FCP. Before doing that, I'd like to get a go from one of the authors as well (infinisil, Robert Hensing (roberth))
All good to me, I haven't pushed anything to the RFC I wouldn't be okay with, would like to hear from Robert Hensing (roberth) as well though. I think niksnut's arguments have been properly addressed here, but it might be proper to add the new arguments to the RFC as well.
10:56:13
@piegames:matrix.org@piegames:matrix.orgtbf I disagree with a couple of points in that comment, but did not want to open a bigger discussion as it is not really central (I would have if GitHub had at least a minimum of threading …)11:00:09
@infinisil:matrix.orginfinisil piegames: How about discussing that here, which points do you disagree with? 11:00:42
@piegames:matrix.org@piegames:matrix.orgthat was my plan, yes :)11:01:16
@j-k:matrix.orgj-k
In reply to @piegames:matrix.org
tbf I disagree with a couple of points in that comment, but did not want to open a bigger discussion as it is not really central (I would have if GitHub had at least a minimum of threading …)
maybe RFC discussions should go in GH Discussions now? 🤷
11:01:31
@qyliss:fairydust.spaceAlyssa RossDiscourse…11:02:07
@infinisil:matrix.orginfinisilLet's not open this meta-discussion for now!11:02:49
@piegames:matrix.org@piegames:matrix.org

if a new contributor opens up a folder and sees gazillion of 2-letter folders - he'll immediately close the tab and go read documentation about it. This is actually a desirable behavior.

For people who are not themselves familiar with sharding, it is best to read an explanation before interacting with it. For people who are - the contents of this folder will make sense immediately.

11:02:51
@j-k:matrix.orgj-kdies discourse actually have threads? I thought it was just quote replies? kind of like you already get in GH PRs11:02:57
@j-k:matrix.orgj-ksure11:02:58
@infinisil:matrix.orginfinisil I'd like to hear piegames thoughts about that comment :) 11:03:00
@j-k:matrix.orgj-k * does discourse actually have threads? I thought it was just quote replies? kind of like you already get in GH PRs11:03:10
@piegames:matrix.org@piegames:matrix.orgY'all, Matrix as threads, use them :)11:03:27
@qyliss:fairydust.spaceAlyssa Rossnot in my client11:03:45
@infinisil:matrix.orginfinisilOh, didn't notice you opened one, I'm still not sure what to think of Matrix threads :P11:03:49
@piegames:matrix.org@piegames:matrix.orgDifficult to put into words exactly why, but it rubs me the wrong way a bit. I think this folder should be documented extensively. And not only in the Nixpkgs manual, also in the contributing.md and honestly I think I'd even put a README.md into that folder that explains it11:04:41
@infinisil:matrix.orginfinisilOh yeah I was just gonna say, the RFC should be changed to allow a readme in there, and ideally ensuring it gets ordered first (not sure if that's possible though)11:05:23
@piegames:matrix.org@piegames:matrix.orgThat's not really possible, especially given that most file viewers put "folders before files"11:06:17
@piegames:matrix.org@piegames:matrix.orgNot sure to which extent this needs to be documented in the RFC vs being an "implementation detail"11:06:40
@infinisil:matrix.orginfinisil A folder called _WhatsThisDirectory containing a readme? :P 11:06:44
@piegames:matrix.org@piegames:matrix.orgIMO won't help11:07:02
@infinisil:matrix.orginfinisilWhy not? It's the first thing you'll see when you look at that directory11:07:54
@qyliss:fairydust.spaceAlyssa Rossdepends on how you're looking at it, no?11:08:08
@qyliss:fairydust.spaceAlyssa Rossi guess most stuff is either alphabetical or directories-first11:08:31
@piegames:matrix.org@piegames:matrix.orgIn GitHub? I'm pretty sure it groups folders before files too, so as the only file it would be the last entry no matter the name11:08:48
@infinisil:matrix.orginfinisil Alyssa Ross: Are you intending to reply in the thread? 11:09:10
@qyliss:fairydust.spaceAlyssa RossI have no idea11:09:14

Show newer messages


Back to Room ListRoom Version: 9