| 27 May 2023 |
 infinisil | phaer: Can you also review/accept the RFC if you're content with it? Then we'd have an accepting review by all shepherds :D | 18:12:57 |
 phaer | In reply to @infinisil:matrix.org
phaer: Can you also review/accept the RFC if you're content with it? Then we'd have an accepting review by all shepherds :D Yes, it's on my list, I'll try to do so on Monday or Tuesday :) | 19:22:57 |
| 28 May 2023 |
|  @printfn:matrix.org removed their profile picture. | 09:04:35 |
| 29 May 2023 |
| phaer | Redacted or Malformed Event | 09:59:13 |
| phaer | In reply to @infinisil:matrix.org
phaer: Can you also review/accept the RFC if you're content with it? Then we'd have an accepting review by all shepherds :D Just did 👍️ | 09:59:33 |
 @piegames:matrix.org | In reply to @infinisil:matrix.org
phaer: Can you also review/accept the RFC if you're content with it? Then we'd have an accepting review by all shepherds :D You sure? I can't find the approval of j-k somehow | 10:17:40 |
 j-k | added | 10:18:38 |
| @piegames:matrix.org | Good. Given that the only remaining discussion point is around the name of the folder, I'd like to go and announce FCP. Before doing that, I'd like to get a go from one of the authors as well (infinisil, Robert Hensing (roberth)) | 10:25:17 |
| infinisil | In reply to @piegames:matrix.org
You sure? I can't find the approval of j-k somehow Oh yeah sorry I must've mixed something up! | 10:52:29 |
| @piegames:matrix.org | Also in the FCP announcement I'll mention that the only open discussion point is the name of the folder, and that the currently proposed unit will be kept unless the discussion converges on a different name. | 10:54:46 |
| infinisil | In reply to @piegames:matrix.org
Good. Given that the only remaining discussion point is around the name of the folder, I'd like to go and announce FCP. Before doing that, I'd like to get a go from one of the authors as well (infinisil, Robert Hensing (roberth)) All good to me, I haven't pushed anything to the RFC I wouldn't be okay with, would like to hear from Robert Hensing (roberth) as well though. I think niksnut's arguments have been properly addressed here, but it might be proper to add the new arguments to the RFC as well. | 10:56:13 |
| @piegames:matrix.org | tbf I disagree with a couple of points in that comment, but did not want to open a bigger discussion as it is not really central (I would have if GitHub had at least a minimum of threading …) | 11:00:09 |
| infinisil | piegames: How about discussing that here, which points do you disagree with? | 11:00:42 |
| @piegames:matrix.org | that was my plan, yes :) | 11:01:16 |
| j-k | In reply to @piegames:matrix.org
tbf I disagree with a couple of points in that comment, but did not want to open a bigger discussion as it is not really central (I would have if GitHub had at least a minimum of threading …) maybe RFC discussions should go in GH Discussions now? 🤷 | 11:01:31 |
 Alyssa Ross | Discourse… | 11:02:07 |
| infinisil | Let's not open this meta-discussion for now! | 11:02:49 |
| @piegames:matrix.org |
if a new contributor opens up a folder and sees gazillion of 2-letter folders - he'll immediately close the tab and go read documentation about it. This is actually a desirable behavior.
For people who are not themselves familiar with sharding, it is best to read an explanation before interacting with it. For people who are - the contents of this folder will make sense immediately.
| 11:02:51 |
| j-k | dies discourse actually have threads? I thought it was just quote replies? kind of like you already get in GH PRs | 11:02:57 |
| j-k | sure | 11:02:58 |
| infinisil | I'd like to hear piegames thoughts about that comment :) | 11:03:00 |
| j-k | * does discourse actually have threads? I thought it was just quote replies? kind of like you already get in GH PRs | 11:03:10 |
| @piegames:matrix.org | Y'all, Matrix as threads, use them :) | 11:03:27 |
| Alyssa Ross | not in my client | 11:03:45 |
| infinisil | Oh, didn't notice you opened one, I'm still not sure what to think of Matrix threads :P | 11:03:49 |
| @piegames:matrix.org | Difficult to put into words exactly why, but it rubs me the wrong way a bit. I think this folder should be documented extensively. And not only in the Nixpkgs manual, also in the contributing.md and honestly I think I'd even put a README.md into that folder that explains it | 11:04:41 |
| infinisil | Oh yeah I was just gonna say, the RFC should be changed to allow a readme in there, and ideally ensuring it gets ordered first (not sure if that's possible though) | 11:05:23 |
| @piegames:matrix.org | That's not really possible, especially given that most file viewers put "folders before files" | 11:06:17 |
| @piegames:matrix.org | Not sure to which extent this needs to be documented in the RFC vs being an "implementation detail" | 11:06:40 |
| infinisil | A folder called _WhatsThisDirectory containing a readme? :P | 11:06:44 |
