!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

234 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture52 Servers

Load older messages


SenderMessageTime
11 May 2023
@infinisil:matrix.orginfinisilNice: https://github.com/NixOS/rfcs/pull/14619:18:46
@infinisil:matrix.orginfinisil Robert Hensing (roberth): Don't feel obliged to join, but I sent you an email invite for tomorrows RFC 140 shepherd meeting, since you're a co-author 22:01:17
@infinisil:matrix.orginfinisil

Robert Hensing (roberth): I made two somewhat noteworthy changes to the RFC I'd like you to review though:

  • I properly documented the interaction with package variants here. I integrated your previously contributed section into other sections.
  • To ensure that new packages use the standard without CI failing for all the existing packages that we can't automatically migrate, I introduced a CI exclusion list to populate during the automatic migration and then exclude those from the CI checks, see [this section](https://github.com/nixpkgs-architecture/rfcs/blob/master/rfcs/0140-simple-package-paths.md#pr-2-automated-migration

And just in general I cleaned up the RFC a bunch, it would be great if you could take a read through it and see if something seems off

22:06:59
@infinisil:matrix.orginfinisil *

Robert Hensing (roberth): I made two somewhat noteworthy changes to the RFC I'd like you to review though:

  • I properly documented the interaction with package variants here. I integrated your previously contributed section into other sections.
  • To ensure that new packages use the standard without CI failing for all the existing packages that we can't automatically migrate, I introduced a CI exclusion list to populate during the automatic migration and then exclude those from the CI checks, see this section

And just in general I cleaned up the RFC a bunch, it would be great if you could take a read through it and see if something seems off

22:09:59
12 May 2023
@federicodschonborn:matrix.org@federicodschonborn:matrix.org changed their profile picture.00:58:26
@lassulus:lassul.uslassulus changed their profile picture.10:11:58
@lassulus:lassul.uslassulus changed their profile picture.13:39:05
@roberthensing:matrix.orgRobert Hensing (roberth) infinisil I thought I responded to join. Do you have a link? 15:03:28
@piegames:matrix.org@piegames:matrix.org
In reply to @infinisil:matrix.org
phaer: j-k: growpotkin ( Alex Ameen ): piegames: I scheduled an RFC 140 shepherd meeting for next Friday, 2023-05-12 17:00 CEST (date -d@1683903600), we'll meet in this jitsi, meeting notes are here. I also sent email invites (except to j-k since I wasn't sure about the email, please PM)
Robert Hensing (roberth) ^
15:03:46
@infinisil:matrix.orginfinisil growpotkin ( Alex Ameen ): RFC 140 meeting time 15:04:07
@roberthensing:matrix.orgRobert Hensing (roberth) infinisil: can't take notes now. Window system crash 15:18:53
@growpotkin:matrix.orgGrowpotkinAre y'all still doing the meeting?15:46:44
@growpotkin:matrix.orgGrowpotkinI was in a meeting for work.15:46:51
@infinisil:matrix.orginfinisilWe were at the time of your message16:36:56
@infinisil:matrix.orginfinisilYou did say you were available at this time though 😅16:37:40
@infinisil:matrix.orginfinisilIf you can't make a meeting I really recommend letting people know in advance!16:38:55
@infinisil:matrix.orginfinisil Robert Hensing (roberth): What do you think of using a pinned version of the lazy trees builtins.filterPath (that's what it's called) in CI to ensure the reference requirement of RFC 140? 17:38:02
@infinisil:matrix.orginfinisilIt's a bit dangerous considering that lazy trees is very unstable and unreviewable, but considering it's only for a limited part of CI, and pinned, it might be okay, it would simplify the implementation a lot17:39:35
@infinisil:matrix.orginfinisil

Oof, actually the error message would be terrible that way.. Since lazy paths have a separate filesystem root, trying to import e.g. ../../../../default.nix (the default.nix in the root) from pkgs/unit/he/hello leads to

error: getting status of '/home/tweagysil/na/nixpkgs/pkgs/unit/he/hello/README.md': No such file or directory
17:55:14
@infinisil:matrix.orginfinisil Oh and in fact it's even worse, because if you try to import ../../../../package.nix, it actually works, but it imports package.nix in the local directory, so ./package.nix! That's really confusing, maybe I should comment this in the lazy trees PR 17:56:40
@infinisil:matrix.orginfinisil The cause of these problems is that the parent of a filesystem root is the filesystem root itself, so /.. == /. 17:57:38
@infinisil:matrix.orginfinisilI reported this here: https://github.com/NixOS/nix/pull/6530#issuecomment-154611077018:14:32
@federicodschonborn:matrix.org@federicodschonborn:matrix.org changed their profile picture.19:34:21
@federicodschonborn:matrix.org@federicodschonborn:matrix.org changed their display name from Federico Schonborn to Federico Damián Schonborn.19:35:02
15 May 2023
@growpotkin:matrix.orgGrowpotkinI had no idea that the date/time had been set14:25:49
@infinisil:matrix.orginfinisil I sent out this message and email invites more than a week in advance 😅 14:26:57
@growpotkin:matrix.orgGrowpotkinDamn, for whatever reason my calendar missed it. Sorry y'all14:33:34
@infinisil:matrix.orginfinisilCan you check if it's in your spam folder? I just got a report that DMARC is apparently messed up for tweag.io..15:09:56
@infinisil:matrix.orginfinisil * Can you check if it's in your spam folder? I just got a report that DMARC for google calendar invites is apparently messed up for tweag.io.. 15:10:21
@whentze:matrix.orgWanja Hentzeoh yeah, that sort of thing has bitten me before15:45:56

Show newer messages


Back to Room ListRoom Version: 9