!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

232 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
22 Mar 2023
@k900:0upti.meK900Honestly, I don't really know11:28:44
@k900:0upti.meK900Presumably some people use it for filtering?11:28:49
@k900:0upti.meK900I don't11:28:52
@piegames:matrix.org@piegames:matrix.orgI think it's kind of useful for reminding involved people about it getting stale. Like, sometimes people just forget with all the stuff they have open11:29:31
@whentze:matrix.orgWanja Hentzesubjectively, I've had an *easier* time getting stuff reviewed and merged recently than I used to 1-2 years ago11:30:07
@whentze:matrix.orgWanja Hentzeregardless of number of open PRs11:30:20
@piegames:matrix.org@piegames:matrix.org
In reply to @piegames:matrix.org
I think it's kind of useful for reminding involved people about it getting stale. Like, sometimes people just forget with all the stuff they have open
Same reminder can be seen as a question, "can this be closed now?". Of course one could also find such PRs through the search, but then a person that was not involved in the discussion at all might have to answer this question. Better ask the people who are already in the thread.
11:31:08
@k900:0upti.meK900
In reply to@whentze:matrix.org
subjectively, I've had an *easier* time getting stuff reviewed and merged recently than I used to 1-2 years ago
Definitely
11:31:07
@k900:0upti.meK900 But also, we have more bandwidth doesn't mean we have enough bandwidth 11:31:13
@whentze:matrix.orgWanja Hentzeyes11:31:21
@piegames:matrix.org@piegames:matrix.orgSo I think I'd be fine without a stale bot whatsoever, but it is not completely useless either11:31:41
@k900:0upti.meK900One of my extremely backburner projects is something like bors for nixpkgs that would allow maintainers to merge changes to their packages without having the commit bit11:31:57
@snowytrees:matrix.orgsnowytreesI personally like it because it’s easier to distinguish unfinished/abandoned PRs from failed ones.11:32:09
@snowytrees:matrix.orgsnowytreesWhen they aren’t closed*11:32:14
@k900:0upti.meK900 That should help a lot with the queue 11:32:16
@piegames:matrix.org@piegames:matrix.org
In reply to @k900:0upti.me
One of my extremely backburner projects is something like bors for nixpkgs that would allow maintainers to merge changes to their packages without having the commit bit
Yes, pretty pretty please. This would enable a lot of things for us
11:32:35
@noob_tea:matrix.orgtea
In reply to @k900:0upti.me
One of my extremely backburner projects is something like bors for nixpkgs that would allow maintainers to merge changes to their packages without having the commit bit
yes
11:34:26
@whentze:matrix.orgWanja Hentze
In reply to @k900:0upti.me
One of my extremely backburner projects is something like bors for nixpkgs that would allow maintainers to merge changes to their packages without having the commit bit
yesss
11:34:36
@noob_tea:matrix.orgteaI think that was discussed in last archteam meeting?11:34:39
@whentze:matrix.orgWanja HentzeI shilled bors there yeah11:34:53
@k900:0upti.meK900The problem is we can't really just do bors because it doesn't understand this kind of thing 11:35:19
@k900:0upti.meK900And any time I think about how to do it properly it ends up in "rewrite hydra lol" 11:35:54
@whentze:matrix.orgWanja Hentzeit doesn't?11:35:57
@piegames:matrix.org@piegames:matrix.org
In reply to @k900:0upti.me
The problem is we can't really just do bors because it doesn't understand this kind of thing
We are large enough to need our own solution, yes
11:36:12
@k900:0upti.meK900It doesn't understand "this person is the maintainer for this package and should be allowed to merge changes to it" 11:37:00
@piegames:matrix.org@piegames:matrix.org
In reply to @k900:0upti.me
And any time I think about how to do it properly it ends up in "rewrite hydra lol"
You really mean Hydra here or rather OfBorg?
11:37:06
@k900:0upti.meK900Both 11:37:12
@k900:0upti.meK900The fact that they're two different things is part of the issue tbh11:37:31
@piegames:matrix.org@piegames:matrix.orgNah, just start your own thing next to OfBorg. I think the GitHub lock-in battle is lost anyways for us, so better embrace it and split it up into smaller pieces11:37:44
@whentze:matrix.orgWanja Hentze
In reply to @k900:0upti.me
It doesn't understand "this person is the maintainer for this package and should be allowed to merge changes to it"
it supports CODEOWNERS, that can do the trick as long as file granularity is good enough
11:38:39

Show newer messages


Back to Room ListRoom Version: 9