| 30 Jan 2023 |
Alyssa Ross | unstableGitUpdater <3 | 17:26:26 |
infinisil | Yeah while working on this I also discovered that most of these file references are actually just anti-patterns and it's often better to get rid of them than to work around them | 17:27:14 |
Sandro 🐧 | but that also blows up the scope massively | 17:29:59 |
infinisil | Yes, so the tooling detects such cases where moving a packages files around would break eval, and just doesn't move those packages (it could give a warning though) | 17:31:45 |
Sandro 🐧 | moving update scripts does not break eval but breaks at execution | 17:36:21 |
Sandro 🐧 | most of those use either cd in code or nix-shell with relative paths in the shebang | 17:36:33 |
infinisil | Not sure yet what to do about that, it seems really tricky to accurately detect this in shell scripts | 17:37:18 |
infinisil | And there's no clear API for these update scripts, they might not even be in passthru.updateScript, they might just be random files that expect to be executed 🤔 | 17:39:18 |
infinisil | After a quick grep for ../, it looks like there's relatively few instances, these could probably be fixed semi-manually | 17:40:04 |
Sandro 🐧 | take https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/ArchiSteamFarm/update.sh as a bad example | 17:40:05 |
Sandro 🐧 | In reply to @infinisil:matrix.org And there's no clear API for these update scripts, they might not even be in passthru.updateScript, they might just be random files that expect to be executed 🤔 we should enforce putting them there otherwise CWD can be anything and you usually have some lines of glue code around that | 17:41:07 |
infinisil | That sounds good, but probably better to keep out of this RFC to not blow up the scope | 17:42:32 |
Wanja Hentze | In reply to @sandro:supersandro.de TBH we should abstract most of those workarounds away and get away from writing those scripts from zero. I'm not going to say the F word but this looks like a problem that might be solvable using a certain experimental nix feature, maybe | 17:46:03 |
Wanja Hentze | or maybe that certain feature needs to accommodate arbitrary updater scripts | 17:46:41 |
Wanja Hentze | In reply to @infinisil:matrix.org We just opened the RFC https://github.com/NixOS/rfcs/pull/140 🎉 also, wtf, now I got the animation when switching to this tab | 18:00:58 |
infinisil | I archived https://github.com/nixpkgs-architecture/simple-package-paths because it would get confusing to get feedback in multiple places and have multiple repositories | 19:06:00 |
| 31 Jan 2023 |
| @blaggacao:matrix.org joined the room. | 03:47:02 |
| 3 Feb 2023 |
@blaggacao:matrix.org | Potential motivation (coutesy of eliminated guesswork):
Scriptable package scraping with e.g. https://discourse.nixos.org/t/nix-init-generate-nix-packages-from-urls-with-hash-prefetching-dependency-inference-license-detection-and-more/25035 | 03:12:11 |
@blaggacao:matrix.org | Don't want to put that one the PR (and increase the noise, there). Just add it if you feel like ... | 03:12:49 |
@blaggacao:matrix.org | * Potential additional motivation (coutesy of eliminated guesswork):
Scriptable package scraping with e.g. https://discourse.nixos.org/t/nix-init-generate-nix-packages-from-urls-with-hash-prefetching-dependency-inference-license-detection-and-more/25035 | 03:13:18 |
| figsoda joined the room. | 04:28:38 |
figsoda | In reply to @blaggacao:matrix.org Potential additional motivation (coutesy of eliminated guesswork): Scriptable package scraping with e.g. https://discourse.nixos.org/t/nix-init-generate-nix-packages-from-urls-with-hash-prefetching-dependency-inference-license-detection-and-more/25035 I was actually looking for this RFC (not created yet at the time) when I was replying to one of the replies in the thread. just happened to look at the rfcs and found this rfc, nice to see you here again | 04:44:52 |
@blaggacao:matrix.org | I wanted to make a script to scrape all mdbook- preprocessors once and for all. But I thought I'd better wait for after this PR. | 04:46:23 |
@blaggacao:matrix.org | * I wanted to make a script to scrape all mdbook- preprocessors once and for all. But I thought I'd better wait for after this RFC landed. | 04:46:37 |
| 5 Feb 2023 |
growpotkin1 | Does repology count JS modules as packages? | 03:43:50 |
growpotkin1 | I think my JS+Nix stuff is ready for use in Nixpkgs if there were any interest in replacing the node2nix infrastructure.
Surprisingly the load on CI is relatively low. I knocked out 18,000 packages from a cold cache in 1.5 hours with a single GitHub box.
The majority of builds run with only jq and stdenv. node is only a dependency for <1% of them. In terms of limiting load on hydra this is an important selling point. | 03:54:03 |
Winter (she/her) | In reply to@growpotkin1:matrix.org
I think my JS+Nix stuff is ready for use in Nixpkgs if there were any interest in replacing the node2nix infrastructure.
Surprisingly the load on CI is relatively low. I knocked out 18,000 packages from a cold cache in 1.5 hours with a single GitHub box.
The majority of builds run with only jq and stdenv. node is only a dependency for <1% of them. In terms of limiting load on hydra this is an important selling point. I think my JS+Nix stuff is ready for use in Nixpkgs if there were any interest in replacing the node2nix infrastructure.
I have an in-progress migration roadmap thing to move to buildNpmPackage and buildYarnPackage, so yeah, there's interest. | 05:17:19 |
growpotkin1 | Sweet. Honestly I worked my ass off on this, I'm excited to get it out there.
I've got npm and yarn v2/3 translation covered already, so this might be a good fit for the migration work | 05:20:33 |
Winter (she/her) | not sure how I feel about having two more or less competing JS build support systems in-tree... | 05:22:31 |
Winter (she/her) | note that I'm biased, as I've worked on my stuff for quite a while as well (and it's already in-tree). | 05:23:22 |