| 8 Dec 2022 |
Wanja Hentze | Oops, didn't look at the timestamp 🫥 | 09:53:57 |
infinisil | Wanja Hentze: Hehe, do you want a ping next time? | 11:05:40 |
Wanja Hentze | yes please! ideally not during my CET working hours :P | 13:28:31 |
Robert Hensing (roberth) | 🎉 opt-in structuredAttrs is close to merge
https://github.com/NixOS/nixpkgs/pull/175649 | 18:54:33 |
| 12 Dec 2022 |
infinisil | @room: The next meeting will take place soon, we will continue discussing issues from https://github.com/nixpkgs-architecture/simple-package-paths - Meeting link - live stream - meeting notes | 15:21:13 |
infinisil | tomberek: growpotkin ( Alex Ameen ): Joining? | 15:33:05 |
tomberek | not today,, sorry | 15:33:34 |
| 14 Dec 2022 |
infinisil | Robert Hensing (roberth) growpotkin ( Alex Ameen ) tomberek John Ericson Please review: https://github.com/nixpkgs-architecture/simple-package-paths/pull/20 | 22:27:13 |
infinisil | We're getting really close to opening an official RFC | 22:27:36 |
| 15 Dec 2022 |
Winter (she/her) | infinisil: Filing an issue is the best way to report feedback, right? Or can/should I just say it here? | 17:25:03 |
Winter (she/her) | (On the auto-called packages draft.) | 17:25:11 |
Winter (she/her) | Ah, my issue was addressed in the above PR. (The detailed design mentioned pkgs/auto instead of unit at the start.) | 17:27:27 |
infinisil | Winter (she/her): Nice :D. But yes feel free to open issues or PR's to that repo | 21:53:00 |
| 16 Dec 2022 |
| Growpotkin joined the room. | 16:54:47 |
Growpotkin | Robert Hensing (roberth): beat me to the punch on just about every comment I was going to add to the RFC haha. Thanks for saving me the effort. | 16:59:56 |
Growpotkin | The only area that I would expand ( possibly in a footnote ) is "why pkg-fun.nix instead of default.nix?". On the surface this change likely seems the largest to an average reader. Something along the lines of "default.nix was never really the appropriate filename, this change leaves default.nix available for it's original purpose for packages which choose to use it, etc..." | 17:02:23 |
Growpotkin | * The only area that I would expand ( possibly in a footnote ) is "why pkg-fun.nix instead of default.nix?". On the surface this change likely seems the largest to an average reader. Something along the lines of "default.nix was never really the appropriate filename based on Nixpkgs' usage. This change leaves default.nix available for it's original purpose for packages which choose to use it, etc..." | 17:02:59 |
Growpotkin | There's likely a way to phrase it that avoids philosophical debate about what default.nix ought to be used for though. It is the internet after all so I'd hate to open up a can of worms that derails relevant discussion. | 17:05:04 |
Growpotkin | Robert Hensing (roberth): any preference on the "common" helper routine for readDir and readFileType living in primops.cc vs util.cc? ( basically DT_* -> char * part ) | 19:45:34 |
Growpotkin | * Robert Hensing (roberth): any preference on the "common" helper routine for readDir and readFileType living in primops.cc vs util.cc? ( basically DT_XXX -> char * part ) | 19:46:41 |
Robert Hensing (roberth) | Growpotkin: I think the char * part is specific to the language, so util doesn't seem right | 19:48:41 |
growpotkin1 | Sounds good. | 19:48:54 |
growpotkin1 | Related : should we be using a symbol here to avoid allocating a billion strings? | 19:49:29 |
Robert Hensing (roberth) | Yeah, good idea | 19:50:02 |
growpotkin1 | Like the ones stashed in baseEnv | 19:50:14 |
Robert Hensing (roberth) | Oh, adding constants to the language? Not sure about that | 19:50:56 |
Robert Hensing (roberth) | That's not something we have generally done | 19:51:15 |
Robert Hensing (roberth) | Yeah not a single string constant there it seems, unless you count the nix version | 19:52:37 |
Growpotkin | we have symbols for null, true, false, etc. That was what I meant ( EvalState has symbols for sWith, sOutPath, etc ) | 19:58:54 |
Growpotkin | * we have symbols for null, true, false, etc ( constants ). But we also have symbols in state - that was what I meant ( EvalState has symbols for sWith, sOutPath, etc ) | 19:59:22 |