!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

236 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
8 Dec 2022
@whentze:matrix.orgWanja HentzeOops, didn't look at the timestamp 🫥09:53:57
@infinisil:matrix.orginfinisil Wanja Hentze: Hehe, do you want a ping next time? 11:05:40
@whentze:matrix.orgWanja Hentzeyes please! ideally not during my CET working hours :P13:28:31
@roberthensing:matrix.orgRobert Hensing (roberth)🎉 opt-in structuredAttrs is close to merge https://github.com/NixOS/nixpkgs/pull/17564918:54:33
12 Dec 2022
@infinisil:matrix.orginfinisil @room: The next meeting will take place soon, we will continue discussing issues from https://github.com/nixpkgs-architecture/simple-package-paths - Meeting link - live stream - meeting notes 15:21:13
@infinisil:matrix.orginfinisil tomberek: growpotkin ( Alex Ameen ): Joining? 15:33:05
@tomberek:matrix.orgtombereknot today,, sorry15:33:34
14 Dec 2022
@infinisil:matrix.orginfinisil Robert Hensing (roberth) growpotkin ( Alex Ameen ) tomberek John Ericson Please review: https://github.com/nixpkgs-architecture/simple-package-paths/pull/20 22:27:13
@infinisil:matrix.orginfinisilWe're getting really close to opening an official RFC22:27:36
15 Dec 2022
@winterqt:nixos.devWinter (she/her) infinisil: Filing an issue is the best way to report feedback, right? Or can/should I just say it here? 17:25:03
@winterqt:nixos.devWinter (she/her)(On the auto-called packages draft.)17:25:11
@winterqt:nixos.devWinter (she/her) Ah, my issue was addressed in the above PR. (The detailed design mentioned pkgs/auto instead of unit at the start.) 17:27:27
@infinisil:matrix.orginfinisil Winter (she/her): Nice :D. But yes feel free to open issues or PR's to that repo 21:53:00
16 Dec 2022
@growpotkin:matrix.orgGrowpotkin joined the room.16:54:47
@growpotkin:matrix.orgGrowpotkin Robert Hensing (roberth): beat me to the punch on just about every comment I was going to add to the RFC haha. Thanks for saving me the effort. 16:59:56
@growpotkin:matrix.orgGrowpotkin The only area that I would expand ( possibly in a footnote ) is "why pkg-fun.nix instead of default.nix?".
On the surface this change likely seems the largest to an average reader.
Something along the lines of "default.nix was never really the appropriate filename, this change leaves default.nix available for it's original purpose for packages which choose to use it, etc..."
17:02:23
@growpotkin:matrix.orgGrowpotkin * The only area that I would expand ( possibly in a footnote ) is "why pkg-fun.nix instead of default.nix?".
On the surface this change likely seems the largest to an average reader.
Something along the lines of "default.nix was never really the appropriate filename based on Nixpkgs' usage. This change leaves default.nix available for it's original purpose for packages which choose to use it, etc..."
17:02:59
@growpotkin:matrix.orgGrowpotkin There's likely a way to phrase it that avoids philosophical debate about what default.nix ought to be used for though. It is the internet after all so I'd hate to open up a can of worms that derails relevant discussion. 17:05:04
@growpotkin:matrix.orgGrowpotkin Robert Hensing (roberth): any preference on the "common" helper routine for readDir and readFileType living in primops.cc vs util.cc? ( basically DT_* -> char * part ) 19:45:34
@growpotkin:matrix.orgGrowpotkin * Robert Hensing (roberth): any preference on the "common" helper routine for readDir and readFileType living in primops.cc vs util.cc? ( basically DT_XXX -> char * part ) 19:46:41
@roberthensing:matrix.orgRobert Hensing (roberth) Growpotkin: I think the char * part is specific to the language, so util doesn't seem right 19:48:41
@growpotkin1:matrix.orggrowpotkin1Sounds good.19:48:54
@growpotkin1:matrix.orggrowpotkin1Related : should we be using a symbol here to avoid allocating a billion strings? 19:49:29
@roberthensing:matrix.orgRobert Hensing (roberth)Yeah, good idea19:50:02
@growpotkin1:matrix.orggrowpotkin1 Like the ones stashed in baseEnv 19:50:14
@roberthensing:matrix.orgRobert Hensing (roberth)Oh, adding constants to the language? Not sure about that19:50:56
@roberthensing:matrix.orgRobert Hensing (roberth)That's not something we have generally done19:51:15
@roberthensing:matrix.orgRobert Hensing (roberth)Yeah not a single string constant there it seems, unless you count the nix version19:52:37
@growpotkin:matrix.orgGrowpotkin we have symbols for null, true, false, etc. That was what I meant ( EvalState has symbols for sWith, sOutPath, etc ) 19:58:54
@growpotkin:matrix.orgGrowpotkin * we have symbols for null, true, false, etc ( constants ). But we also have symbols in state - that was what I meant ( EvalState has symbols for sWith, sOutPath, etc ) 19:59:22

Show newer messages


Back to Room ListRoom Version: 9