!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

231 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
15 Dec 2023
@infinisil:matrix.orginfinisil Philip Taron: That would be great! Just wrote a top-level comment too :) https://github.com/NixOS/nixpkgs/pull/272395#issuecomment-1857050220 00:12:48
@philiptaron:matrix.orgPhilip Taron (UTC-8)Have you read this? https://qntm.org/ratchet00:16:49
@infinisil:matrix.orginfinisil Philip Taron: No but I'll take a look now, seems relevant! 00:18:47
@infinisil:matrix.orginfinisilDone, yeah that's the general idea :D00:22:40
@philiptaron:matrix.orgPhilip Taron (UTC-8)I find the name really great. At work, we write these kind of "ratchet linters" all the time. Usually just a sqlite database + some regexs. It helps having a concept for them, since they're strictly speaking not really a test (pass / fail) they're.. their own thing.00:23:57
@infinisil:matrix.orginfinisilAh yeah, the name is really great, I guess it would be nice to change the name of the concept in the by-name tool!00:25:20
@philiptaron:matrix.orgPhilip Taron (UTC-8)Gave you a ✅ after reading through the code.00:26:53
@infinisil:matrix.orginfinisil

Btw the RFC specifies to do it in a different way, but the basic idea is the same:

All satisfying definitions that can't be automatically migrated due to the above restrictions will be added to a CI exclusion list. CI is added to ensure that all satisfying definitions except the CI exclusion list must be using the new directory structure. This means that the new directory structure becomes mandatory for new satisfying definitions after this PR. The CI exclusion list should be removed eventually once the non-automatically-migratable satisfying definitions have been manually migrated. Only in very limited circumstances is it allowed to add new entries to the CI exclusion list.

00:27:33
@philiptaron:matrix.orgPhilip Taron (UTC-8)I'm all about the spirit dominating the letter.00:28:27
@infinisil:matrix.orginfinisilI'm planning to merge https://github.com/NixOS/nixpkgs/pull/272395 once CI passes so I can move onto the follow-up PR16:48:29
@philiptaron:matrix.orgPhilip Taron (UTC-8)Sounds good to me.16:50:25
@nbp:mozilla.orgnbp changed their display name from nbp to nbp {pto}.19:40:55
@nbp:mozilla.orgnbp changed their display name from nbp {pto} to nbp.19:41:16
@kity:kity.wtfproblemshttps://github.com/NixOS/nixpkgs/issues/273972 this seems like a good architecture issue21:53:58
16 Dec 2023
@infinisil:matrix.orginfinisilNot sure, it's an interesting idea, but I don't think it's an overarching issue with Nixpkgs architecture02:31:44
19 Dec 2023
@infinisil:matrix.orginfinisil Oh nice, https://github.com/NixOS/nixpkgs/pull/255023 added an unnecessary callPackage ../by-name/... { }, which won't be possible anymore after https://github.com/NixOS/nixpkgs/pull/274591, but the existing definition won't give an error! 02:38:34
@infinisil:matrix.orginfinisil That second PR is almost ready btw, after that's merged I can work on making pkgs/by-name mandatory for new packages! 02:39:32
@infinisil:matrix.orginfinisilPS: I moved the 4-weekly meeting by 2 weeks from 2023-12-26 to 2024-01-09 to avoid the holidays :)16:43:56
@infinisil:matrix.orginfinisil This PR is ready now, reviews (by anybody) appreciated: https://github.com/NixOS/nixpkgs/pull/274591
I'd like to merge it as soon as possible, ideally this week
Ping the NAT Robert Hensing (roberth), John Ericson, Growpotkin, DavHau, tomberek
22:38:32
20 Dec 2023
@infinisil:matrix.orginfinisil And I also went ahead with a draft of the next step after the above, enforcing new packages to use pkgs/by-name: https://github.com/NixOS/nixpkgs/pull/275539 01:17:15
@roberthensing:matrix.orgRobert Hensing (roberth)
In reply to @infinisil:matrix.org
And I also went ahead with a draft of the next step after the above, enforcing new packages to use pkgs/by-name: https://github.com/NixOS/nixpkgs/pull/275539
It says: This PR is a draft and isn't ready to be reviewed yet
16:33:11
@infinisil:matrix.orginfinisil Robert Hensing (roberth): This one is ready: https://github.com/NixOS/nixpkgs/pull/274591 16:34:36
@roberthensing:matrix.orgRobert Hensing (roberth)Just read that one16:34:58
@infinisil:matrix.orginfinisil Robert Hensing (roberth): Ah yes, thanks, just addressed that 16:39:08
21 Dec 2023
@infinisil:matrix.orginfinisilUnless there's opposition, I'll merge https://github.com/NixOS/nixpkgs/pull/274591 later today19:01:05
23 Dec 2023
@raitobezarius:matrix.orgraitobezarius changed their display name from raitobezarius to raitobezarius (DECT 2128).22:22:09
25 Dec 2023
@lassulus:lassul.uslassulus changed their display name from lassulus to lassulus (8587).22:41:42
28 Dec 2023
@piegames:matrix.org@piegames:matrix.org changed their display name from piegames to piegames ☎ 9712.01:33:05
@piegames:matrix.org@piegames:matrix.org changed their display name from piegames ☎ 9712 to piegames [☎ 9712].01:33:13
30 Dec 2023
@roberthensing:matrix.orgRobert Hensing (roberth)An instance of package metadata that really shouldn't be on a package attrset (passthru etc). https://github.com/NixOS/nixpkgs/pull/277221/files#r143856656811:35:03

Show newer messages


Back to Room ListRoom Version: 9