!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

227 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

Load older messages


SenderMessageTime
27 Sep 2023
@poweruser64:matrix.orgPowerUser64yeah not much that can be done now10:10:46
@poweruser64:matrix.orgPowerUser64Redacted or Malformed Event10:11:08
@poweruser64:matrix.orgPowerUser64I hope it all goes well in the end10:11:34
@infinisil:matrix.orginfinisilI really think most people do agree with how it's going. I don't think there was a single person arguing for keeping the directory structure throughout the RFC10:13:00
@infinisil:matrix.orginfinisil Being able to tell new contributors "if you want to package foo, put it here" is very nice 10:13:51
@poweruser64:matrix.orgPowerUser64Maybe #146 can help remedy some of my frustrations10:15:14
@lassulus:lassul.uslassulusI think cateories should be a list in the meta field rather than a folder stuff is in10:16:01
@piegames:matrix.org@piegames:matrix.org
In reply to @infinisil:matrix.org
I really think most people do agree with how it's going. I don't think there was a single person arguing for keeping the directory structure throughout the RFC
Yep, the discussion skipped the contents of the RFC entirely and directly jumped to the bike shedding part ^^
10:16:15
@syphoxy:matrix.org@syphoxy:matrix.orgRFC 146 is really promising and I hope it goes through as quickly as RFC 140 did.14:17:09
@piegames:matrix.org@piegames:matrix.orgI'm not optimistic about that. 140 enjoyed a wide community consensus which is otherwise pretty rare15:26:47
@infinisil:matrix.orginfinisilI'm tending towards accepting 146, it's not bad. However I also think it's a distraction from other problems that would be more important to fix17:24:12
@infinisil:matrix.orginfinisilLosing the categorisation seems very minor in comparison17:28:02
@infinisil:matrix.orginfinisilUnrelated to that, an observation relating to PR CI checks in general: Aren't they kind of flawed? Because the main branch continuously updates, but the CI checks for each PR aren't re-run17:32:53
@k900:0upti.meK900They are17:33:07
@k900:0upti.meK900Ideally we'd have bors17:33:11
@k900:0upti.meK900But it's hard17:33:28
@piegames:matrix.org@piegames:matrix.orgAnd is it worth the effort?17:33:44
@infinisil:matrix.orginfinisilI guess merge trains would improve on that17:33:45
@k900:0upti.meK900
In reply to@piegames:matrix.org
And is it worth the effort?
I think it's worth considering in the general effort to fix our CI situation
17:34:14
@k900:0upti.meK900Is it worth doing by itself? Probably not17:34:24
@k900:0upti.meK900Is it worth doing as part of a bigger project to replace hydra/ofborg/etc? Absolutely yes17:34:49
@infinisil:matrix.orginfinisil piegames: On the scale of Nixpkgs it might be, because we have so many PR's, many of which linger around for a while 17:34:53
@infinisil:matrix.orginfinisilAny CI checks that newly fail would then break on master when those PR's are merged17:35:11
@infinisil:matrix.orginfinisilIn particular I'm thinking of https://github.com/NixOS/nixpkgs/pull/211832#issuecomment-1732153092 here17:35:54
@piegames:matrix.org@piegames:matrix.orgBtw this has a hard dependency of going through a merge bot for everything17:36:14
@infinisil:matrix.orginfinisil The first step should be to disallow definitions in all-packages.nix when they should be in pkgs/by-name instead. But if we just put that in a CI check, it would fail regularly for probably some days as people merge all-packages.nix changes in 17:36:48
@k900:0upti.meK900
In reply to@piegames:matrix.org
Btw this has a hard dependency of going through a merge bot for everything
Not necessarily
17:36:57
@k900:0upti.meK900But I also don't think this is too bad, generally17:37:13
@piegames:matrix.org@piegames:matrix.orgOh I absolutely do want a merge bot, and soon pretty please17:37:49
@infinisil:matrix.orginfinisilThe idea given here should help for some cases: https://github.com/NixOS/nixpkgs/issues/25678817:38:34

Show newer messages


Back to Room ListRoom Version: 9