| 21 Apr 2024 |
 terru | Question about environment variables which nixpkgs reads to configure itself: these all have the prefix NIXPKGS_ or NIXOS_, except NIX_ABORT_ON_WARN. I find this very confusing, as it suggests that this variable is read by nix itself, which it is not. It was introduced in #140763, apparently without consideration of this inconsistency. Is there any good reason why it should not be called NIXPKGS_ABORT_ON_WARN instead, and if not, what is the process to change it? rename it, and for a release cycle still also accept the old variant, but produce a trace if it is set? | 17:22:53 |
 Qyriad | See also: NIX_DEBUG | 17:29:31 |
 infinisil | In reply to @terru:raccoon.college
Question about environment variables which nixpkgs reads to configure itself: these all have the prefix NIXPKGS_ or NIXOS_, except NIX_ABORT_ON_WARN. I find this very confusing, as it suggests that this variable is read by nix itself, which it is not. It was introduced in #140763, apparently without consideration of this inconsistency. Is there any good reason why it should not be called NIXPKGS_ABORT_ON_WARN instead, and if not, what is the process to change it? rename it, and for a release cycle still also accept the old variant, but produce a trace if it is set? Yeah that sounds like a good plan to me. I'd make the deprecation period longer though, it doesn't cost much | 20:04:18 |
| 22 Apr 2024 |
 willbush | 
Download 20240421_21h04m39s_grim.png | 02:05:07 |
| willbush | Any idea why 3 of the by-name checks would trigger at the same time for https://github.com/NixOS/nixpkgs/pull/305879? | 02:05:21 |
| willbush | Maybe could be fixed by https://docs.github.com/en/actions/using-jobs/using-concurrency | 02:13:34 |
| willbush | Maybe?:
concurrency:
group: ${{ github.ref }}
cancel-in-progress: true
| 02:15:32 |
| willbush | It's sort of a micro-optimization though in the shadow of-borg | 02:17:34 |
| willbush | * It's sort of a micro-optimization though in the shadow ofborg | 02:17:46 |
| willbush changed their profile picture. | 07:10:21 |
| terru | it does have the (very slight) cost of "someone will have to remember to remove the extra code which implements the warning" ;)
in any case, I've opened a PR for this now: https://github.com/NixOS/nixpkgs/pull/306026 | 15:21:33 |
| infinisil | willbush: Yeah sounds like you're right on. Feel free to PR if you want! | 15:56:39 |
| infinisil | I'm in the weekly office hour: https://meet.jit.si/nixpkgs-architecture (cc Philip Taron (UTC-8), willbush, Dominic Mills) | 18:00:34 |
 Philip Taron (UTC-8) | I'm skipping today. Gotta do work for work. | 18:01:10 |
