| 15 Apr 2024 |
 infinisil | Personal office hour now: https://meet.jit.si/nixpkgs-architecture | 18:00:06 |
| infinisil | Cc Philip Taron (UTC-8) willbush | 18:00:22 |
| infinisil | I want to figure out changelogs for nixpkgs-check-by-name today: https://github.com/NixOS/nixpkgs-check-by-name/issues/38 | 18:01:52 |
| 16 Apr 2024 |
| infinisil | Result is really neat, though I had to write some custom scripts: https://github.com/NixOS/nixpkgs-check-by-name/pull/46 | 02:01:24 |
| 17 Apr 2024 |
|  K900 changed their display name from K900 ⚡️ to K9Ö0. | 17:16:43 |
| K900 changed their display name from K9Ö0 to K900. | 17:21:54 |
| K900 | 17:21:55 |
| 18 Apr 2024 |
| infinisil | willbush: Thanks a lot for all the recent reviews, I really appreciate it! ❤️ Would you be interested in getting write access to the repository? :D (cc Philip Taron (UTC-8)) | 12:18:49 |
 willbush | infinisil: No problem! Sure! =D | 14:33:36 |
 Philip Taron (UTC-8) | I think it's a good idea. 👍️ | 16:02:56 |
| infinisil | willbush: Alright! Unfortunately I can't add you right now since you're not part of the NixOS organisation. Can you make a PR to add yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix? This way you should automatically get an invite for the org, after which I can give you write access | 16:25:29 |
| 19 Apr 2024 |
| infinisil | willbush: You've got write permission now! 🎉 | 05:56:00 |
| willbush | Thanks! | 06:10:02 |
| 20 Apr 2024 |
| willbush | Question on pull request etiquette.
The people I work with at work, we happen to be using GitHub as well, and the person creating the PR usually usually merges the PR. If they want it merged immediately after approval, then they check an auto-merge box (enable in repo settings).
I'm not very experienced working with others in open source (yet :D). What is proper PR etiquette?
| 04:54:40 |
| willbush | * Question on pull request etiquette.
The people I work with at work, we happen to be using GitHub as well, and the person creating the PR usually merges the PR. If they want it merged immediately after approval, then they check an auto-merge box (enable in repo settings).
I'm not very experienced working with others in open source (yet :D). What is proper PR etiquette?
| 04:55:05 |
| willbush | * Question on pull request etiquette.
The people I collaborate with at work, we happen to be using GitHub as well, and the person creating the PR usually merges the PR. If they want it merged immediately after approval, then they check an auto-merge box (enable in repo settings).
I'm not very experienced working with others in open source (yet :D). What is proper PR etiquette?
| 04:55:44 |
| 21 Apr 2024 |
| infinisil | In reply to @willbush:matrix.org
Question on pull request etiquette.
The people I work with at work, we happen to be using GitHub as well, and the person creating the PR usually merges the PR. If they want it merged immediately after approval, then they check an auto-merge box (enable in repo settings).
I'm not very experienced working with others in open source (yet :D). What is proper PR etiquette?
The approach I'm using and I think works really well, is to mark PRs as a draft if you don't think they're ready for merging. So by default, any non-draft PR is ready for merge according to the author | 11:46:57 |
