| 8 Feb 2024 |
 infinisil | For pkgs/by-name, here's a code refactoring that discovered a bug: https://github.com/NixOS/nixpkgs/pull/287083
Feel free to review, but I intend to self-merge this week
| 00:16:26 |
 Philip Taron (UTC-8) | In reply to @infinisil:matrix.org
For pkgs/by-name, here's a code refactoring that discovered a bug: https://github.com/NixOS/nixpkgs/pull/287083
Feel free to review, but I intend to self-merge this week
✅, good to merge | 01:25:24 |
| infinisil | Philip Taron (UTC-8): Nice, thanks for the quick review | 01:31:53 |
| infinisil | * Philip Taron (UTC-8): Nice, thanks for the quick review! | 01:31:55 |
| Philip Taron (UTC-8) | In reply to @infinisil:matrix.org
Philip Taron (UTC-8): Nice, thanks for the quick review! And ✅ again. | 01:40:13 |
| infinisil | ❤️ | 01:40:25 |
| infinisil | Philip Taron (UTC-8): Btw the ratchet stuff allows some really nice follow ups for the automated migration | 01:40:58 |
| infinisil | Currently this ToNixpkgsProblem trait only has one method to compare two Nixpkgs versions against each other (or rather, give an appropriate error for that): https://github.com/NixOS/nixpkgs/blob/master/pkgs/test/nixpkgs-check-by-name/src/ratchet.rs#L77-L88 | 01:41:58 |
| infinisil | To implement migration, we can just add another method to the trait, which gets the value of a single Loose ratchet, which are exactly the ones that can be migrated! | 01:43:09 |
