!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

226 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture50 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
12 Sep 2023
@infinisil:matrix.orginfinisilI think the github UI allows either rebasing or merging10:37:29
@qyliss:fairydust.spaceAlyssa Ross we don't currently have merge commits everywhere 10:37:47
@infinisil:matrix.orginfinisil (by default rebase should be good, but as Profpatsch hints at, merging sometimes makes sense) 10:37:55
@qyliss:fairydust.spaceAlyssa Rosswe have a combination of all kinds of merges, based on what each committer thinks is best at the time10:38:12
@piegames:matrix.org@piegames:matrix.orgWhat would be needed here IMO is rebase + merge with trivial merge commit. 10:38:19
@qyliss:fairydust.spaceAlyssa Rossyeah we definitely want merge for e.g. staging-next10:38:21
@qyliss:fairydust.spaceAlyssa Ross what would be the point of the merge commit? 10:38:35
@qyliss:fairydust.spaceAlyssa Rossalso, if git can figure out renames on rebasing, I think it should be able to figure them out on merging too/10:38:53
@piegames:matrix.org@piegames:matrix.org
In reply to @qyliss:fairydust.space
what would be the point of the merge commit?
To associate the individual commits with the PR
10:39:06
@qyliss:fairydust.spaceAlyssa Rossthat's not something we do today10:39:19
@qyliss:fairydust.spaceAlyssa Ross(across the board, at least)10:39:31

Show newer messages


Back to Room ListRoom Version: 9